No style for menulist on dark background

RESOLVED FIXED in fennec1.0b5

Status

Firefox for Android Graveyard
General
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Fabrice Desré, Assigned: Fabrice Desré)

Tracking

Fennec 1.1
fennec1.0b5
x86
All

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
There is no class usable to display a <menulist/> on a dark background.
(Assignee)

Comment 1

9 years ago
Created attachment 405430 [details] [diff] [review]
fix

The patch adds a "menu-dark" class to style menulists on dark backgrounds
Comment on attachment 405430 [details] [diff] [review]
fix

I think we should name the new class "button-dark" for consistency. We can change it to "control-dark" or something if we want it to be generic.

r+ with the name change, which I can do on checkin
Attachment #405430 - Flags: review+
pushed:
https://hg.mozilla.org/mobile-browser/rev/ba67a4a1743b
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → B5
Would about:config on an inverted theme be a proper testcase for this patch?
(In reply to comment #4)
> Would about:config on an inverted theme be a proper testcase for this patch?

Nope. There are no menulists in the about:config
bug 517459 has code and a screenshot of dark menulists working
You need to log in before you can comment on or make changes to this bug.