521456 - Incorrect decompilation with "new eval"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

js> (function() { new(eval('({s:1})').s) })
(function () {new eval("({s:1})").s;})
js> (function () {new eval("({s:1})").s;})
(function () {(new eval("({s:1})")).s;})

At some point, the error message for executing the function changes from
TypeError: eval("({s:1})").s is not a constructor
to
EvalError: function eval must be called directly, and not by way of a function of another name

None of this happens with a function with a name other than eval:

js> (function() { new(eeee('({s:1})').s) }) 
(function () {new (eeee("({s:1})").s);})

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 420805 [details] [diff] [review]
Patch

I think you need JSOP_APPLY in that list as well. r=me with that looked into.

Comment 3

[Jeff Walden [:Waldo]]

http://hg.mozilla.org/tracemonkey/rev/8a19567a3633

(with JSOP_APPLY addressed and tested as well, thanks for noting that)

Comment 4

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/8a19567a3633