521463 - text input fields are different widths on enter_bug.cgi, process_bug.cgi and post_bug.cgi

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect, P3)

Description

[David Lawrence [:dkl]]

Attachment: Patch to add bodyclasses to process_bug.cgi and post_bug.cgi (v1)

bug/show.html.tmpl includes additional bodyclasses that use CSS to format the text input fields to min: 25em and width: 100%. bug/process/header.html.tmpl and bug/create/created.html.tmpl do not include the additional bodyclasses and so therefore the text input fields are smaller at size=40. 

Needs to be consistent for all views of bug/edit.html.tmpl.

Attaching patch.

Dave

Comment 1

[Max Kanat-Alexander]

Comment on attachment 405543 [details] [diff] [review]
Patch to add bodyclasses to process_bug.cgi and post_bug.cgi (v1)

Hmm. The process one should definitely have the classes, but the enter_bug one should probably have a separate class, and then that should be used in the CSS.

By the way, I don't know if I have a bug filed for this, but we need to centralized the header values for all the ways that there are to reach the bug/show.html template.

Comment 2

[Max Kanat-Alexander]

If this is still a problem, we really should fix this for 4.0. It's been around for too long.

Comment 3

[Max Kanat-Alexander]

Attachment: v1

Okay, this at least sychronizes the CSS somewhat between enter_bug and show_bug.

We can't actually make the text inputs 100% width on enter_bug, because that actually makes them the size of the screen. But this cleans up the CSS between enter_bug and show_bug, and makes the text inputs scale somewhat to the size of the screen on enter_bug.

There's no good way to sync the Comment field with the text fields, because the Comment field uses a different font. (When you combine this with cross-browser and cross-platform compatibility, and the fact that the actual width of displayed comments is limited in em, then there's no good way to handle it.)

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 456179 [details] [diff] [review]
v1

Looks good to me and works as expected. r=dkl

Comment 5

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified skins/standard/enter_bug.css
modified skins/standard/global.css
modified skins/standard/show_bug.css
modified template/en/default/bug/create/create.html.tmpl
Committed revision 7338.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.0/                         
modified skins/standard/enter_bug.css
modified skins/standard/global.css
modified skins/standard/show_bug.css
modified template/en/default/bug/create/create.html.tmpl
Committed revision 7313.