521477 - Build warning: "mkdir: cannot create directory `gfx/cairo/cairo/src/cairo-features.h': File exists"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Daniel Holbert [:dholbert]]

I frequently notice this build warning/error fly by, when I'm rebuilding mozilla-central:
> mkdir: cannot create directory `gfx/cairo/cairo/src/cairo-features.h': File exists
> creating gfx/cairo/cairo/src/cairo-features.h/Makefile
> $SRC/build/autoconf/make-makefile: Cannot read $SRC/gfx/cairo/cairo/src/cairo-features.h/Makefile.in: No such file or directory
(I've replaced my source dir with $SRC, for shorter lines)

It looks like some component of the build system thinks that "cairo-features.h" is a *directory* with a Makefile.in file inside of it, and it tries to generate a Makefile in the corresponding directory in the objdir.

In reality, there is no cairo-features.h file (or directory) in our source tree.  But there *is* a "cairo-features.h.in" file, which ends up generating a .h file in the objdir.

Comment 1

[Daniel Holbert [:dholbert]]

I'm not sure what exactly is making us look for this directory, or what the correct fix is, but from a quick mxr search for "cairo-features.h", I'm guessing the (partly-)responsible code is one of the following.

Either this chunk:

> 46 SUBMAKEFILES    += cairo-features.h
http://hg.mozilla.org/mozilla-central/annotate/7a931f8811fa/gfx/cairo/cairo/src/Makefile.in#l46
(This line was added in bug 328116.)

OR, this chunk:

> 1057 if [ "$MOZ_TREE_CAIRO" ] ; then
> 1058   add_makefiles "
> 1059     gfx/cairo/Makefile
> 1060     gfx/cairo/libpixman/src/Makefile
> 1061     gfx/cairo/cairo/src/Makefile
> 1062     gfx/cairo/cairo/src/cairo-features.h
> 1063   "
> 1064 fi
http://hg.mozilla.org/mozilla-central/annotate/7a931f8811fa/toolkit/toolkit-makefiles.sh#l1057
(This block of code was originally added to the file "allmakefiles.sh" in bug 290518, and it was subsequently moved to its current location in toolkit-makefiles.sh).

Comment 2

[(not currently active) Ted Mielczarek]

It's probably this:
http://mxr.mozilla.org/mozilla-central/source/config/rules.mk#1583
http://mxr.mozilla.org/mozilla-central/source/build/autoconf/make-makefile#192

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Ah ha, this is the ? in

http://hg.mozilla.org/mozilla-central/rev/29ba8085d9f6