521479 - Change personas extension to use headerURL and footerURL instead of header and footer

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Personas Plus, defect)

Description

[Toby Elliott [:telliott]]

These are duplicated information, and the uplift guys are using the full headerURL and footerURL. We should be able to transition the current version without anything changing and eventually deprecate header and footer

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Yup, this should be a trivial change, as the client currently resolves header and footer values relative to a base URL using a Firefox API that correctly handles both absolute and relative URLs (prepending the base URL to relative URLs while leaving absolute URLs alone), so this is as simple as making the client use headerURL and footerURL instead of header and footer; no change in logic should be required.

Comment 2

[Jose E. Bolanos]

Attachment: Patch, replacing header with headerURL and footer with footerURL

This patch changes the use of persona.header and persona.footer to persona.headerURL and persona.footerURL respectively, adjusting any other related code.

I'm submitting a patch instead of committing directly since I'm now using a new account (@appcoast.com). Thanks.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 410068 [details] [diff] [review]
Patch, replacing header with headerURL and footer with footerURL

getpersonas.com headerURL and footerURL values are currently absolute, but they shouldn't have to be, so keep the code for resolving those values relative to the site's base URL.

Otherwise this looks great.


> I'm submitting a patch instead of committing directly since I'm now using a new
> account (@appcoast.com). Thanks.

That shouldn't affect your ability to commit changes.  Give it a try!

Comment 4

[Jose E. Bolanos]

I was finally able to commit the changes (changeset e0626ec264ce).

@Myk - Since this is my first commit, please review it let me know if everything is OK. Thanks.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Looks great!