521536 - Allow user search by external id when using env authentication

Status: RESOLVED FIXED

(Bugzilla :: User Accounts, enhancement)

Description

[Tiago Mello [:timello]]

It would be nice if we can search for users by external id.

Comment 1

[Tiago Mello [:timello]]

Attachment: Adds user search by external id

Comment 2

[Jochen Wiedmann]

This would certainly be a nice thing to have. However, the patch depends on the current extern_id handling, which uses a parameter:

    IF Param('auth_env_id')

As such, it is mutually exclusive with the patch to bug 423612. I'd propose to change the patch to use

    IF user.authorizer.extern_id_used

or

    IF user.authorizer.extern_id_used or Param('auth_env_id')

This would allow us, to declare this bug as a dependending on bug 423612 and pull both in at one go.

Comment 3

[Max Kanat-Alexander]

Comment on attachment 405625 [details] [diff] [review]
Adds user search by external id

>+[% IF Param('auth_env_id') %]
>+  [% columns.push({name        => 'extern_id'
>+                   heading     => 'External id'

  I think our new standard terminology for this is External Login ID.

>Index: template/en/default/admin/users/search.html.tmpl
>+  [% IF Param('auth_env_id') %]
>+    <option value="extern_id">external id</option>

   Needs to be fixed here, too.

  That can all be done on checkin, though.

Comment 4

[Max Kanat-Alexander]

Comment on attachment 405625 [details] [diff] [review]
Adds user search by external id

Oh, actually, when I went to go check this in, I noticed a problem--it assumes that extern_id is only used when Param('auth_env_id') is enabled, which isn't true--LDAP uses extern_id too, any any login method can use extern_id. mockodin has a patch that accounts for that, so perhaps we should wait for that first.

Comment 5

[Frédéric Buclin]

We are going to branch for Bugzilla 4.4 next week and this bug is either too invasive to be accepted for 4.4 at this point or shows no recent activity. The target milestone is reset and will be set again *only* when a patch is attached and approved.

I ask the assignee to reassign the bug to the default assignee if you don't plan to work on this bug in the near future, to make it clearer which bugs should be fixed by someone else.

Comment 6

[Albert Ting]

Attachment: bug-84313-search-extern-user

Turns out I needed this and the effort seems notably smaller since the last update.

Comment 7

[David Lawrence [:dkl]]

Comment on attachment 8818370 [details] [diff] [review]
bug-84313-search-extern-user

Review of attachment 8818370 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

::: template/en/default/admin/users/search.html.tmpl~
@@ +32,4 @@
>    <option value="login_name">login name</option>
>    <option value="realname">real name</option>
>    <option value="userid">user id</option>
> +  <option value="extern_id">extern id</option>

<option value="extern_id">external id</option>

Will fix on commit.

Comment 8

[David Lawrence [:dkl]]

To https://github.com/bugzilla/bugzilla.git
   3fb30ab..1a0c543  master -> master