Closed Bug 521576 Opened 15 years ago Closed 9 years ago

gfx qt: Build failure: syntax error in cairoint.h: extra comma at enum end

Categories

(Core Graveyard :: Widget: Qt, defect)

x86
Linux
defect
Not set
major

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: BenB, Assigned: BenB)

Details

Attachments

(1 file)

Reproduction: - hg mozilla-central trunk - configure --enable-default-toolkit=cairo-qt - make Actual result: cairo-qpainter-surface.cpp: cairoint.h:2537: error: comma at end of enumerator list No wonder, there's indeed a syntax error: enum { CAIRO_PATTERN_ACQUIRE_NONE = 0x0, CAIRO_PATTERN_ACQUIRE_NO_REFLECT = 0x1, }; Bad merge? Nobody compiling it?
Attached patch Fix syntax errorSplinter Review
Assignee: nobody → ben.bucksch
Attachment #405677 - Flags: review?(jmuizelaar)
Summary: gfx qt: Build failure: → gfx qt: Build failure: syntax error in cairoint.h: extra comma at enum end
I don't understand why --enable-default-toolkit=cairo-qt is needed for this error. i.e. trunk compiles just fine.
because the cairo-qpainter-surface.cpp, which includes the header, may be compiled with different compiler flags, or using this in different context, or whatever. Does it matter? It's a syntax error.
Comment on attachment 405677 [details] [diff] [review] Fix syntax error Fair enough. Please include the patch against upstream cairo like the other patches in the cairo directory.
Attachment #405677 - Flags: review?(jmuizelaar) → review+
Thanks. Well do and commit later (Monday or later).
In bug 1282866, I have removed the QT code from the Firefox tree with the approval of the active peer. That code is not currently maintained by any team. I have looked through the bugs in the Widget: Qt bugzilla component and I believe all of these are no longer relevant because the Qt code has been removed. If you believe that this bug is still valid, please move it to another more appropriate bugzilla component as you reopen it.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INCOMPLETE
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: