521587 - Set MOZ_MACBROWSER=1 in confvars.sh

Status: RESOLVED INVALID

(Camino Graveyard :: General, defect)

Description

[[e-mail]]

Set MOZ_MACBROWSER=1 in confvars.sh
As discussed on IRC:
--------------
[20:19] ardissone: in confvars.sh you want to
[20:20] ardissone: MOZ_MACBROWSER=1
[20:21] ardissone: configure no longer sets that, for some reason
[20:22] ardissone: actually, file a bug on camino; we should be setting that ourselves, according to the comments in 1.9.0 configure.in
--------------

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Less sure that this is going to do what we want, because even m-c's configure.in still does

AC_DEFINE(MOZ_PHOENIX)

for Firefox, and because setting MOZ_MACBROWSER=1 in confvars.sh didn't get Kai beyond the the error he was seeing in spellhcheck.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

No, it was bug 437219 that we're looking for, at least to solve Kai's build error in spellcheck on m-c.

On >1.9.0 we'll need an app-config.mk that looks like http://mxr.mozilla.org/comm-central/source/suite/app-config.mk (s/SUITE/MACBROWSER/g); we could use this on 1.9.0, too, but in 1.9.0 we're still in configure(.in), so there's no real benefit.

I think right now that we should mark this bug INVALID; we don't need it at all on 1.9.0 (contrary to what the comment in configure implies), and when we have a working build on mozilla-central (or whatever), we should file bugs on specific problems (e.g., general Camino build-config changes, history changes, project/packaging changes, etc.) and add patches there.