52159 - Site name should be added to allow/block cookie/image dialog (in place of "this site")

Status: VERIFIED WONTFIX

(Core :: Networking: Cookies, defect, P4)

Description

[Henrik Gemal]

When selecting block cookies/image from this site, a dialog appear saying 
"Cookies/Images from this site will always be rejected".
This dialog should contain the sites URL. So it should say something like:
"Cookies/Images from the site www.gemal.dk will always be rejected."

Comment 1

[Jesse Ruderman]

*** Bug 67785 has been marked as a duplicate of this bug. ***

Comment 2

[Viswanath Ramachandran]

not a netscape beta stopper. 

Comment 3

[Jeremy M. Dolan]

Site name is displayed in the cookie dialog. How about image dialog?

Comment 4

[R.K.Aa.]

*** Bug 110713 has been marked as a duplicate of this bug. ***

Comment 5

[Eric Vaandering (no email)]

Using RC1, from Tool -> (Cookie/Image Manager) the site is not displayed.
Neither is the site displayed in the context menu when right clicking on an image.

When selecting these options, an Alert pops up, but the name is still not
displayed. 

Comment 6

[Wayne Scott]

Galeon puts the site name in the context menu:
  Block images from ads.cnn.com

I was rather surprised Mozilla didn't work the same way.

This is much nicer than putting it a dialog box because it
lets the user know if that image is useful to block with only
one click.

Of course, the dialog box should also have the site name.

Comment 7

[Lorenzo Colitti]

I have a patch for the image context menu. With the patch, the context menu
displays "Block(Unblock) Images from www.site.com" instead of "Block (Unblock)
Images from this Server".

Before posting the diff, though, I'd like to see if people (especially the UI
folks who would make the decision of checking it in or not) are in favour of it.
I wouldn't want it to die out like bug 136110...

Comment 8

[Stephen P. Morse]

This was intentionally never done because it would make the drop-down menu
excessively wide.

Comment 9

[Lorenzo Colitti]

Attachment: Image context menu patch

This patch puts the server name in the "Block Images" context menu item.

Comment 10

[Lorenzo Colitti]

On the other hand, if you actually want to *use* Block Images from this server,
95% of the time you first have to view the image properties (right-click image,
select Properties, close properties dialog) just to make sure you're not
blocking the main site's content.

Steve: here's the patch. I'm not going to defend it (although it doesn't look
too wide to me, and it's really a necessary feature if you use image blocking).
If it needs work for review, I'll do it (if the server name is too long, it can
be truncated: domain names are < 64 chars and must be in US-ASCII, so "..." is
probably OK). But if you don't want it, hey, it's your module. Don't let me stop
you. I don't want to do bug 136110 over again. :)

Comment 11

[Lorenzo Colitti]

(although, of course, in bug 136110 you were on my side. ;-) )

Comment 12

[Lorenzo Colitti]

Attachment: Screenshot of wide context menu

Screenshot of patched version on a web site with a long name. It doesn't look
unmanageable to me. But then, I'm not an average user. :-)

(no more, I promise!)

Comment 13

[Darin Fisher]

-> suresh

Comment 14

[Suresh]

hmm...as Lorenzo and Morse mentioned, the context menu might look very wide
depending on length of the domain name. This might not look good visually in
most cases. (see attachment 105412 [details])

darin/danm/cathleen: what do you folks think?

thx!

Comment 15

[Suresh]

Adding Jennifer to cc list. 

Jen, when you get a chance can you look at this bug? 
I personally feel that adding domain name will make the context menu wide. 

Thanks!!!

Comment 16

[Suresh]

-> WONTFIX.

Patrice (UE Engineer) didn't like increasing the width of the context-menu.

Comment 17

[benc]

V/wontfix.
Made image blocking bugs depends on this, one component someday changes its mind.