Closed Bug 521654 Opened 10 years ago Closed 9 years ago

Add "Open All..." to File > Attachments Menu

Categories

(Thunderbird :: Toolbars and Tabs, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.3a1

People

(Reporter: bugzilla2007, Assigned: bugzilla2007)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

In File > Attachments Menu, there should be "Open all..." in addition to "Save all", "Detach all" and "Delete all". 

I'm always up for consistency and added-value. This is an easy one, 2 lines to add. If you point me to the file, I'll do it.

STR
1 go file > attachments
2 look at options for all attachments of the message:
Save all, Detach all, Delete all
3 now look at attachment1 [details] [diff] [review] > commands:
Open, Save, Detach, Delete

Actual result
Guess what's missing

Expected result
I want to open them, all at once, right here from the menu.
Just as I can save them, all at once.
But I don't want to save them before opening them.
I don't want to open them individually.
Just all of them, one go.

When you're at it, please also fix this for context menu in attachment pane, at least for the one that has the "<action> all" commands on it (can get on blank spot of panel).
The patch adds "Open All..." to File > Attachments Menu only.
Bryan, to ease your UI review, here's a screenshot of patch attachment 456753 [details] [diff] [review] in action... This patch adds missing "Open all..." command to File > Attachments Menu (just as we now have "Save all...", "Detach all..." and "Delete all...").

Benefits:
- consistency with menus for *individual* attachments (which all have *Open*, Save, Detach, Delete)
- the *only* way for people who deliberately use the menu to efficiently open ALL attachments (otherwise, they can only open each attachment individually).
- no fuss, no clutter, and no changes to main attachment UI: we're adding just a single sweet line that integrates seamlessly into a menu where only interested users will ever see it.
- we add a lot of value for those who just want to *open* all attachments (as opposed to saving them). Lots of everyday scenarios, e.g.
   - want to just print all attachments without saving them
   - want to just look at all attachments before deciding which to save
   - want to just look at all attachments to search for something,
     to decide on best version, rename each and save, edit each and save, etc.
It's the typical office worker who wants a neat pile of paper files on his desktop before acting on them one by one in a top-down approach.

Guaranteed focus-hassle-free 8)
Your benevolent UI review will be appreciated :)
Comment on attachment 456754 [details]
Screenshot1 of Patch1: Add "Open All..." to File > Attachments Menu

Bryan, to ease your UI review, here's a screenshot of patch attachment 456753 [details] [diff] [review]
in action... This patch adds missing "Open all..." command to File >
Attachments Menu (just as we now have "Save all...", "Detach all..." and
"Delete all...").

Benefits:
- consistency with menus for *individual* attachments (which all have *Open*,
Save, Detach, Delete)
- the *only* way for people who deliberately use the menu to efficiently open
ALL attachments (otherwise, they can only open each attachment individually).
- no fuss, no clutter, and no changes to main attachment UI: we're adding just
a single sweet line that integrates seamlessly into a menu where only
interested users will ever see it.
- we add a lot of value for those who just want to *open* all attachments (as
opposed to saving them). Lots of everyday scenarios, e.g.
   - want to just print all attachments without saving them
   - want to just look at all attachments before deciding which to save
   - want to just look at all attachments to search for something,
     to decide on best version, rename each and save, edit each and save, etc.
It's the typical office worker who wants a neat pile of paper files on his
desktop before acting on them one by one in a top-down approach.

Guaranteed focus-hassle-free 8)
Your benevolent UI review will be appreciated :)
Attachment #456754 - Flags: ui-review?(clarkbw)
Attachment #456753 - Attachment is patch: true
Comment on attachment 456754 [details]
Screenshot1 of Patch1: Add "Open All..." to File > Attachments Menu

looks good, thanks for the screenshot.  sorry for the delay in response, i'm catching up again.
Attachment #456754 - Flags: ui-review?(clarkbw) → ui-review+
Comment on attachment 456753 [details] [diff] [review]
Patch1: Add "Open All..." to File > Attachments Menu

Mark, a simple 4-liner for review. Not sure if this needs any conditions or disabling sometimes?

fwd Bryan's uireview+ from previous comment
Attachment #456753 - Flags: ui-review+
Attachment #456753 - Flags: review?(bugzilla)
Comment on attachment 456753 [details] [diff] [review]
Patch1: Add "Open All..." to File > Attachments Menu

Re disabling, from what I can tell the attachments options are enabled/disabled via the option on the top-level File menu, and not the individual elements, so we're fine there.

> <popup id="attachmentMenuList">
>   <menuseparator/>
>+  <menuitem id="file-openAllAttachments" label="&openAllAttachmentsCmd.label;" 
>+    accesskey="&openAllAttachmentsCmd.accesskey;" oncommand="HandleAllAttachments('open');" />
>   <menuitem id="file-saveAllAttachments" label="&saveAllAttachmentsCmd.label;" 
>     accesskey="&saveAllAttachmentsCmd.accesskey;" oncommand="HandleAllAttachments('save');"/>

So I know you're following the style of the bits around it, but I think it would be better for accesskey to line up with id, and oncommand to be on the next line.

I've tidied that up and checked it in for you: http://hg.mozilla.org/comm-central/rev/dab9787ecdb5
Attachment #456753 - Flags: review?(bugzilla) → review+
Assignee: nobody → bugzilla2007
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.2a1
Thank you!
Blocks: 656078
You need to log in before you can comment on or make changes to this bug.