Closed Bug 521766 Opened 12 years ago Closed 12 years ago

about:privatebrowsing onload handler needlessly delays work

Categories

(Firefox :: Private Browsing, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
Firefox 3.7a1

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: perf, polish, Whiteboard: [tsnap])

Attachments

(1 file)

Attached patch patchSplinter Review
First of all we should use DOMContentLoaded instead of the load event, since we only care about the DOM tree to be ready. And then there's stuff that doesn't even need the complete DOM tree: setting the page title (doing this earlier might help with bug 513420 too), setting the favicon, and focusing the location bar.

This makes especially a difference when loading about:privatebrowsing outside of PB mode. Currently I always see the wrong title flash briefly, and if my system is busy I even see the wrong content briefly.
Attachment #405832 - Flags: review?(ehsan.akhgari)
Severity: normal → minor
Keywords: polish
Whiteboard: [tsnap]
Attachment #405832 - Flags: review?(ehsan.akhgari) → review+
http://hg.mozilla.org/mozilla-central/rev/31096afe0b97
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
Attachment #405832 - Flags: approval1.9.2?
Comment on attachment 405832 [details] [diff] [review]
patch

approval1.9.2 requests aren't currently being monitored, since we're nearing RC freeze and there are too many outstanding requests, so I'm clearing this request. Feel free to re-request approval if you are confident that it's worth drivers' time to consider whether this non-blocker needs to land for 1.9.2 at this stage.
Attachment #405832 - Flags: approval1.9.2?
You need to log in before you can comment on or make changes to this bug.