521766 - about:privatebrowsing onload handler needlessly delays work

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

First of all we should use DOMContentLoaded instead of the load event, since we only care about the DOM tree to be ready. And then there's stuff that doesn't even need the complete DOM tree: setting the page title (doing this earlier might help with bug 513420 too), setting the favicon, and focusing the location bar.

This makes especially a difference when loading about:privatebrowsing outside of PB mode. Currently I always see the wrong title flash briefly, and if my system is busy I even see the wrong content briefly.

Comment 1

[(no longer active)]

Comment on attachment 405832 [details] [diff] [review]
patch

r=me.

Comment 2

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/31096afe0b97

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 405832 [details] [diff] [review]
patch

approval1.9.2 requests aren't currently being monitored, since we're nearing RC freeze and there are too many outstanding requests, so I'm clearing this request. Feel free to re-request approval if you are confident that it's worth drivers' time to consider whether this non-blocker needs to land for 1.9.2 at this stage.