521873 - VERBOSE mode, remove -memstats and -memstats-vebose flags

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect, P3)

Description

[Rick Reitmaier]

These flags are now super-ceded by the following -Dverbose options:

 -memstats         =>  -Dverbose=memstats,sweep
 -memstats-verbose =>  -Dverbose=memstats,sweep,occupancy

Dependency on part 4 of bug 476785, which has landed.

Comment 1

[Brent Baker]

Will -memstats go away? This will remove the ability to run memstats on non-debugger builds.

Comment 2

[Lars T Hansen]

(In reply to comment #1)
> Will -memstats go away? This will remove the ability to run memstats on
> non-debugger builds.

-memstats can't be dependent on AVMPLUS_VERBOSE, it never was but it might be now.  That seems wrong.  (It also can't be debug-only.)

Also, -memstats-verbose /probably/ should not depend on AVMPLUS_VERBOSE, and definitely can't be a debug-only facility.

This may all be my fault for misleading Rick...

Comment 3

[Rick Reitmaier]

To be clear, I haven't modified any part of -memstats and -memstats-verbose, they work as always.

What I did was expose the similar functionality through -Dverbose, thinking that we could eventually remove the -memstats flag. 

It looks like we probably shouldn't, as the options are needed outside AVMPLUS_VERBOSE and exposing -Dverbose in this fashion seems rather odd. 

One thing I did do was remove the help documentation for -memstats, so at the very least we'll need to add that back.

Comment 4

[Lars T Hansen]

(In reply to comment #3)
> One thing I did do was remove the help documentation for -memstats, so at the
> very least we'll need to add that back.

Ah, that's why I was confused.  Yeah, just add that back and we should all be happy.

Comment 5

[Rick Reitmaier]

pushed http://hg.mozilla.org/tamarin-redux/rev/530671caccc9

Comment 6

[Chris Peyer]

Engineering work item.  Marking as verified.