521881 - TM: make Allocator chunk size customizable and don't free the initial chunk upon reset()

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect, P2)

Description

[Andreas Gal :gal]

This is meant to make temporary allocators go to the heap less often.

Comment 1

[Andreas Gal :gal]

Attachment: patch

Comment 2

[Andreas Gal :gal]

Blocking a blocker.

Comment 3

[Damon Sicore (:damons)]

Marking blocking 1.9.2+ so we can get them landed asap.  Blocks the perf bug 517909.

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 405919 [details] [diff] [review]
patch

Would be nice to have a better name than "set" but I can't think of one. setInitialChunk? setChunk?

Comment 5

[Andreas Gal :gal]

http://hg.mozilla.org/tracemonkey/rev/188cf7548d85

Comment 6

[Damon Sicore (:damons)]

Unblocking beta on this.  P2.

Comment 7

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/188cf7548d85

Comment 8

[Robert Sayre]

Andreas backed this out. do we still want it?

Comment 9

[Andreas Gal :gal]

We had a ts regression so we backed out this patch. The cause was probably unrelated though. We should try to land it again.

Comment 10

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Is it still on tracemonkey?  Not sure from the combination of comments and flags.

Also, are we sure we need to block on it?  (I should ask that of and in bug 517909, too, I suppose.)

Comment 11

[Andreas Gal :gal]

We don't have to block on this. Its a minor performance improvement.

Comment 12

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Yarr!

Comment 13

[Ryan VanderMeulen [:RyanVM]]

This was backed out and never re-landed. Clearing the fixed flag.

Comment 14

[Nochum Sossonko [:Natch]]

These bugs are all part of a search I made for js bugs that are getting lost in
transit:

http://tinyurl.com/jsDeadEndBugs

They all have a review+'ed, non-obsoleted patch and are not marked
fixed-in-tracemonkey or checkin-needed but have not seen any activity in 300
days. Some of these got lost simply because the assignee/patch provider never
requested a checkin, or just because they were forgotten about.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Obsolete with the removal of tracejit.