521893 - Why do we have both manageHistory: and showHistory:?

Status: VERIFIED WORKSFORME

(Camino Graveyard :: History, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

[2:51pm] cl: why do we have two different action names for history, anyway?
[2:51pm] cl: showHistory vs manageHistory
[2:51pm] cl: wouldn't it be better if we just had one?
[2:52pm] ardissone: i'd say so :P

MainMenu.nib is picking up MainController's showHistory:, which, uh, calls BWC's manageHistory:, whereas the toolbar button calls manageHistory: directly.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

As Stuart noted the other night, showHistory: (the menu) makes sure that we have a BrowserWindow before calling manageHistory: and creates one if there's not one.  Since the toolbar button is by its very nature part of a browser window, it's not necessary for it to do the extra work.

I think we probably just need to suck it up and validate both separately.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #1)
> I think we probably just need to suck it up and validate both separately.

Which is more-or-less what we did in bug 316835.