521930 - Running maemkit + testagent cannot push files into path with spaces

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[cmtalbert]

I haven't debugged yet to figure out if this is a maemkit issue or a test-agent issue, but if you do the following:
1. Setup your CE device to have firefox installed at \program files\firefox\firefox.exe (the default)
2. Run maemkit to push the testing profile to the device, use "\program files\firefox\firefox.exe" (with quotes) as the appname in your maemkit.cfg file and "\program files\firefox" as the log location (with quotes).

= Expected =
It would push the files and all would be well

= Actual =
It fails to push the files.

Note that the test-agent can start the program properly if you send exec the string (with quotes) "\program files\firefox\firefox.exe" so, I tend to think we should first look at mamekit to see if ce.py is doing something funny when it tries to push the files, but I haven't debugged it anymore than that yet.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

after looking into this, test-agent push is terminating the file name on one of these characters: ' \r\n\t'.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

fixed with http://hg.mozilla.org/users/blassey_mozilla.com/test-agent/rev/21584d04fb86

this fixes push, cat, rmdr and mkdr for paths with spaces.  copy and move use currently use space and tab to separate the two paths so I won't change that behavior until joel has had a chance to update his scripts.  closing.