Closed Bug 521970 Opened 10 years ago Closed 10 years ago

Remove the ContinueParsing() method

Categories

(Core :: HTML: Parser, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: hsivonen, Assigned: hsivonen)

References

()

Details

Attachments

(1 file, 1 obsolete file)

It seems that ContinueParsing() is dead code both in the old parser and in the HTML5 parser. If so, it should be removed.
Attached patch Zap the method (obsolete) — Splinter Review
Attachment #406451 - Flags: superreview?(mrbkap)
Attachment #406451 - Flags: review?(mrbkap)
Forgot to change IID. Sorry for the spam.
Attachment #406451 - Attachment is obsolete: true
Attachment #407233 - Flags: superreview?(mrbkap)
Attachment #407233 - Flags: review?(mrbkap)
Attachment #406451 - Flags: superreview?(mrbkap)
Attachment #406451 - Flags: review?(mrbkap)
Comment on attachment 407233 [details] [diff] [review]
Zap the method and change IID

Good call! I'm glad to see that the original cause of the two parsing methods was fixed for real.
Attachment #407233 - Flags: superreview?(mrbkap)
Attachment #407233 - Flags: superreview+
Attachment #407233 - Flags: review?(mrbkap)
Attachment #407233 - Flags: review+
Status: NEW → ASSIGNED
Thanks for the r/sr.

Landed as http://hg.mozilla.org/mozilla-central/rev/1e2197526df0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.