52199 - Unable to Paste duplicate URLs into same bookmark's folder

Status: VERIFIED DUPLICATE of bug 41502

(SeaMonkey :: Bookmarks & History, defect, P3)

Description

[Randell Jesup [:jesup] (needinfo me)]

FreeBSD 4.1 20000910xx

Tried to copy a few folders and then paste (in Manage Bookmarks)

Got this JS error:
->>>>>>>>>>>>>> Read Clipboard from memory
************************************************************
** NOTE: This report will only be printed in DEBUG builds.**
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "[JavaScript Warning: "assignment to undeclared variable
pasteNodeRes" {file: "chrome://communicator/content/bookmarks/bookmarks.js"
line: 339}]"  nsresult: "0x80570021
(NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame ::
chrome://communicator/content/bookmarks/bookmarks.js :: doPaste :: line 339" 
data: yes]
************************************************************
An error occurred executing the cmd_paste command

Comment 1

[Claudius Gayle]

rjesup, please list specific steps to repro with expected vs. actual results.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Open bookmark manager
Select a bookmark
Edit menu -> Copy
Select another bookmark
Edit menu -> Paste

Expected result: bookmark is pasted
Actual result: error as given

Comment 3

[Claudius Gayle]

Hmmm, I can't be of much help here. Copy and paste works fine on Linux RH6 with the
2000091308 build. The caveat being that you of course can't copy a bookmark to the
same level of the tree hierarchy that it already exists on. So to test I naturally pasted my
copy into a folder. Trying to paste at the same level failed silently.

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

I _was_ trying to paste it at the same level.  There was no reason I should
assume it shouldn't work (I can see the logic of that, but it's not intuitive to
the user!  At least not without notification!)

You didn't get the js exception below?  Were you using a --enable-debug build? 
Sounds like the error in pasting (duplicate) is being return to the JS which
doesn't handle the error.

Comment 5

[Claudius Gayle]

I should note I'm using optimized builds. I do get js errors in my terminal window
but not assertions and whatnot.

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Aha.  As per the output:
** NOTE: This report will only be printed in DEBUG builds.**

So, I'd say there are two things here: one that it silently doesn't paste a link 
at the same level (which is at least confusing), and two that it when it fails 
to paste a link it gets an unhandled error (exception) (which if it pasted the 
link would not be an issue).

Is the disallowing of duplicate links in the same folder a formal UI decision?  
Is it an artifact of the code, or an off-the-cuff decision by the implementer?  
I know ns4.7 and I believe IE allow duplicate links at the same level.

Comment 7

[Claudius Gayle]

seeing as it's slamm's last day i'm reassigning to, instead of cc'ing rjc.
Robert, there are few bugs floating around that touch on the issue of duplicate bookmarks,
and the ramications of having/trying to create them, care to comment?

Comment 8

[Marcia Knous [:marcia]]

Netscape Nav Triage Team: dupe, depends on single bookmarks.

Comment 9

[Fabian Guisset]

Randell, is this still happening in the new bookmarks manager?

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

Still there.  The only thing that changed is that it doesn't print an error.  To
repeat my last comment:

Is the disallowing of duplicate links in the same folder a formal UI decision?  
Is it an artifact of the code, or an off-the-cuff decision by the implementer?  
I know ns4.7 and I believe IE allow duplicate links at the same level.

I strongly object to this behavior, at least without notification.  It breaks
the user's expectations about how copy and paste work.  If we wanted to add a
requester saying "You already have a bookmark to that site in this folder, do
you want to add another copy?", that'd be ok.

Removing target 'future', adding nomination for 1.0

Comment 11

[Fabian Guisset]

sounds good and fair to me

Comment 12

[Claudius Gayle]

to answer randell, as I understand it this is an artifact of the code. I believe it has since been
reworked to not have that dependency anymore.
I believe this bug has XP implications and i believe it has most likely been dealt with
elsewhere whilst this bug has been languishing assinged to someone no longer affiliated with
the project.

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

This is still a bug as of about a week ago, and I just retested with a build
from yesterday and it's still there, so I don't think it's been fixed in the
meantime (unless you mean that there's something it depends on that was broken
and has since been fixed, and no one has updated bookmarks yet).

Comment 14

[Claudius Gayle]

ok. I think this is a dupe, it's just a question of finding it...

Comment 15

[Claudius Gayle]

I believe this is a dupe of bug 41502. That's just a more general case where the folder
in question is the root bookmarks folder.

Comment 16

[Randell Jesup [:jesup] (needinfo me)]

Agreed, DUP

*** This bug has been marked as a duplicate of 41502 ***

Comment 17

[Claudius Gayle]

thanks rj. VERIFIED Dupe