Closed Bug 522001 Opened 11 years ago Closed 7 years ago
[pa-IN] Choose search plug-ins for Fennec in Punjabi
You've indicated an interest in participating in the localization of mobile Firefox (aka Fennec). We want to ship Fennec with a good list of search engines for Punjabi. As the technical details of implementation are being worked on, we'd like to start the discussion about the choice of search engines. This bug is about agreeing on a set of search engines, and will not tackle the implementation (at least not yet). First, the localization team and Staś will look at the market for the locale and come up with a good set of search providers. The guidelines for making recommendations are on https://wiki.mozilla.org/L10n:Mobile/Productization. You're welcome to suggest engines already shipped in desktop Firefox for Punjabi, if they fit well in the categories outlined on the wiki. For en-US, we currently use the following set, which may serve as an inspiration: Google, Wikipedia, Amazon, Yahoo, Twitter. Note that according to the guidelines, for some categories it may be better to leave them empty than to ship with en engine that's irrelevant or unavailable in your region. After we decided on a particular search engine, we will need to test it in Fennec. You can test on a mobile device and on the desktop (download the builds from <http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/>). Staś will help with testing on a device, too. If the service works fine, Staś will contact the owner and ask for permission, and for specifics like proper search flags. $name, we'll likely need your help to at least get the contact information if we don't have them already. We don't know the implementation details yet, so for now, please don't create patches nor land anything. We will keep you posted as we figure out the how's and when's. Thanks.
Hi Amanpreet: Just a friendly reminder, as we move closer to the general availability date for Fennec in mid-December, has your team had any chance to consider search providers? Thanks!
Here's a patch resetting the mobile/searchplugins/ directory to a minimal set of search engines that we would like to ship your locale with. Please read this comment carefully before you land this patch. *Important*: There has been a change to how we use the <Description/> elements present in the plug-ins (see bug 528655 and bug 529869). We want to emphasize that the search is integrated with the browser to better reflect what a search plugin is and what it does. You will need to edit the Wikipedia plug-in before you commit this patch. Please read <https://wiki.mozilla.org/L10n:Integrated_Search_Instructions> for detailed instructions. For Google and Twitter, we don't have to copy the XML files to your mobile/searchplugins/ directory. Plugins identical to en-US are pulled from source automatically. It's enough to put the engine's name in list.txt for this to work (which I did). I also updated the Wikipedia plug-in to use a bigger icon, see bug 517997 for details. Please edit the Wikipedia plug-in and commit this patch before you opt-in in the mozilla.dev.l10n newsgroup. Opt-ins without this patch will not be taken. This does not mean that we don't want to include other search engines. On the contrary, the work and the discussion will continue in this bug until we choose a good set of search engines for your locale. Then, you will be able to opt in again, so that in the final release we include more search engines than the mineral set from this patch. This patch is simply meant to reset your mobile/searchplugins directory so that we keep the repository clean and happy. Thanks for understanding!
patch -p0 < patchfile is not working with given patch, can you please help me? --- The next patch would delete the file a/mobile/searchplugins/amazondotcom.xml, which does not exist! Assume -R? [n] n Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -----
Status: NEW → ASSIGNED
(In reply to comment #3) > patch -p0 < patchfile is not working with given patch, can you please help > me? You need to do | patch -p1 < patchfile |. -p1 will strip the "a/" from the beginning of "a/mobile/searchplugins/amazondotcom.xml".
ok, thanks for help. it is committed with following revision: cac09bfa2831
It looks like you have forgotten to "hg addremove" after having applied the patch and before landing http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/pa-IN/rev/cac09bfa2831. The wikipedia-pa.xml file is missing from <http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/pa-IN/file/cac09bfa2831/mobile/searchplugins>, and google.xml, amazondotcom.xml, wikipedia.xml and yahoo.xml shouldn't be there. Please run "hg addremove" and commit the changes again.
Hope this will work. 158:3536f97ba85b
Looks good indeed :) Can you opt in as well, please?
Can you make the status on l10n-central match that of 1.9.2, too? I'll reject the sign-offs 'til then. Also, on l10n-central, the file permissions seem to be all executable, still, I recall we fixed that on 1.9.2, too.
(In reply to comment #9) > Can you make the status on l10n-central match that of 1.9.2, too? I'll reject > the sign-offs 'til then. > I just committed same changes to l10n-central, Thanks for hint, status page should has some way > Also, on l10n-central, the file permissions seem to be all executable, still, I > recall we fixed that on 1.9.2, too. I am not sure but my use of'cp' command (on Linux) has creating some issue Can you please help me to change permission. I will fresh checkout then.
Ok, sign-off for fennec 4 taken :-) I also landed a permissions mass-change, http://hg.mozilla.org/l10n-central/pa-IN/rev/3c0f650d66c5. hg pull -u should work allright, or grab a new clone.
Anything pending in this bug? Can somebody please close if not required anymore?
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.