522096 - [autoconfig] wrong popup on Username in account test

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect, P3)

Description

[Richard Marti (:Paenglab)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; de-DE; rv:1.9.3a1pre) Gecko/20091013 Minefield/3.7a1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.5pre) Gecko/20091013 Lightning/1.0pre Shredder/3.0pre

The popup on the green bubble of Username says: 'Congratulations! This is a secure server.'. Username has nothing to do if the server is secure or not. It would be better, if the popup says something like 'Username exists' or no popup appears.

Reproducible: Always

Steps to Reproduce:
1. Open account autoconfig
2. Enter some entrys
3. Let's the account test
Actual Results:  
Wrong popup as in image in attachment is viewable

Expected Results:  
Appropriate text in popup or no popup

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Popup with wrong text

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Yup.  Heck, I'ld go further, and say that the green ball should probably not be there at all until we test the username, which is at the very end of the process.

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

Yeah, if we remove the green ball from the username until it's actually checked we won't have to show this tooltip at all.  That also avoids the need for new strings which we can't really add right now.

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Attachment: A patch to remove the ball.

And while I was there, I made it handle a bad password a little better (by putting the user back into edit mode, so that they could fix the username/password and try again).

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Attachment: The previous patch, without the alert dialog.

So, philor asked about removing the alert, cause it looks odd, and doesn't really add a lot, and so here's a patch.

Bryan, what do you think of this version?  Do you agree that it's obvious enough when you get the password wrong?

Thanks,
Blake.

Comment 6

[Phil Ringnalda (:philor)]

Comment on attachment 407067 [details] [diff] [review]
A patch to remove the ball.

r=me, for either version.

Comment 7

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 407074 [details] [diff] [review]
The previous patch, without the alert dialog.

this looks good to me. one less alert dialog!

Comment 8

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/9276f90716d8