Closed Bug 522096 Opened 11 years ago Closed 11 years ago

[autoconfig] wrong popup on Username in account test

Categories

(Thunderbird :: Account Manager, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0rc1

People

(Reporter: Paenglab, Assigned: bwinton)

Details

(Whiteboard: [no l10n impact])

Attachments

(2 files, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; de-DE; rv:1.9.3a1pre) Gecko/20091013 Minefield/3.7a1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.5pre) Gecko/20091013 Lightning/1.0pre Shredder/3.0pre

The popup on the green bubble of Username says: 'Congratulations! This is a secure server.'. Username has nothing to do if the server is secure or not. It would be better, if the popup says something like 'Username exists' or no popup appears.

Reproducible: Always

Steps to Reproduce:
1. Open account autoconfig
2. Enter some entrys
3. Let's the account test
Actual Results:  
Wrong popup as in image in attachment is viewable

Expected Results:  
Appropriate text in popup or no popup
Attached image Popup with wrong text
Flags: blocking-thunderbird3?
Yup.  Heck, I'ld go further, and say that the green ball should probably not be there at all until we test the username, which is at the very end of the process.
Assignee: nobody → bwinton
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P3
Yeah, if we remove the green ball from the username until it's actually checked we won't have to show this tooltip at all.  That also avoids the need for new strings which we can't really add right now.
Hardware: x86 → All
Whiteboard: [no l10n impact]
Target Milestone: --- → Thunderbird 3.0rc1
Version: unspecified → Trunk
Attached patch A patch to remove the ball. (obsolete) — Splinter Review
And while I was there, I made it handle a bad password a little better (by putting the user back into edit mode, so that they could fix the username/password and try again).
Attachment #407067 - Flags: ui-review?(clarkbw)
Attachment #407067 - Flags: superreview?(bienvenu)
Attachment #407067 - Flags: review?(philringnalda)
Whiteboard: [no l10n impact] → [no l10n impact][patch up, needs r/sr/ui-r]
Attachment #407067 - Flags: superreview?(bienvenu) → superreview+
So, philor asked about removing the alert, cause it looks odd, and doesn't really add a lot, and so here's a patch.

Bryan, what do you think of this version?  Do you agree that it's obvious enough when you get the password wrong?

Thanks,
Blake.
Attachment #407074 - Flags: ui-review?(clarkbw)
Attachment #407067 - Flags: review?(philringnalda) → review+
Comment on attachment 407067 [details] [diff] [review]
A patch to remove the ball.

r=me, for either version.
Comment on attachment 407074 [details] [diff] [review]
The previous patch, without the alert dialog.

this looks good to me. one less alert dialog!
Attachment #407074 - Flags: ui-review?(clarkbw) → ui-review+
Attachment #407067 - Attachment is obsolete: true
Attachment #407067 - Flags: ui-review?(clarkbw)
Attachment #407074 - Flags: approval-thunderbird3+
http://hg.mozilla.org/comm-central/rev/9276f90716d8
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: blocking-thunderbird3?
Resolution: --- → FIXED
Whiteboard: [no l10n impact][patch up, needs r/sr/ui-r] → [no l10n impact]
You need to log in before you can comment on or make changes to this bug.