522151 - [SUMO] Forum links in My Account->My Watches are not pretty

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task, P1)

Description

[Vishal Kamdar [:vish_moz]]

Summary: [SUMO] Forum links in My Account->My Watches are not pretty

Pre-condition: You need to be watching a forum topic

Steps to reproduce:
1. log into SUMO Stage
2. go to My Account->My Watches
3. click on one of the forum you are watching


expected result:
forum url will be in the new format, https://support-stage.mozilla.org/en-US/forum/1/446834

actual result:
forum URL is in the old format, https://support-stage.mozilla.org/tiki-user_watches.php?locale=en-US

Comment 1

[James Socol [:jsocol, :james]]

Attachment: patch, v1

This reorders the parameters for new watches so they will be friendly from now on.

Unfortunately, any extant watches will not be updated. They go to the right place, they just aren't friendly.

Comment 2

[Paul Craciunoiu [:paulc]]

Comment on attachment 406149 [details] [diff] [review]
patch, v1

This works for me, except you missed a spot: there's another instance of add_user_watch in tiki-view_forum.php:470 & 473

This code is fine, but let's do it all in one patch.

Comment 3

[James Socol [:jsocol, :james]]

Attachment: patch, v2

Good eye, thanks.

Comment 4

[Paul Craciunoiu [:paulc]]

Comment on attachment 406470 [details] [diff] [review]
patch, v2

WFM

Comment 5

[James Socol [:jsocol, :james]]

r53493

Comment 6

[Vishal Kamdar [:vish_moz]]

Verified, FIXED.

Comment 7

[James Socol [:jsocol, :james]]

r53502 (prod)

Comment 8

[David Tenser [:djst]]

Not sure how we'll handle our URL rewrites when upstreaming. I've seen a lot of bugs related to it and they might have the same solution?

Comment 9

[Paul Craciunoiu [:paulc]]

Bug 522813 and 522814 are about how to make this more centralized. There's really not much to upstream until we get to those.