Closed
Bug 522165
Opened 16 years ago
Closed 16 years ago
Skip linked list walk in CodeAlloc::flushICache when not built with --enable-valgrind
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: jruderman, Unassigned)
Details
Attachments
(1 file)
|
1.08 KB,
patch
|
graydon
:
review-
|
Details | Diff | Splinter Review |
I'm not sure this is needed. Graydon, what do you think?
Attachment #406146 -
Flags: review?(graydon)
|
||
Comment 1•16 years ago
|
||
Nit-o-rama: One space after the #, not two spaces, is house style.
/be
|
Reporter | |
Comment 2•16 years ago
|
||
I was just trying to match the nearby code ;)
|
||
Comment 3•16 years ago
|
||
Comment on attachment 406146 [details] [diff] [review]
patch
I appreciate the concern here, but am going to decline. We've reorganized this code further recently, and while it does not do away with the dead loop in the x86 no-valgrind case in its new form, it would also be (IMO) uglier than it's worth to migrate this patch to the new structure. It's not likely a long loop in any case, probably only 1 or 2 entries long in most cases.
Attachment #406146 -
Flags: review?(graydon) → review-
|
|
Reporter | |
Comment 4•16 years ago
|
||
ok
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•