522174 - Busted ICO file results in a bunch of assertions

Status: RESOLVED WORKSFORME

(Core :: Graphics: ImageLib, defect)

Description

[Jesse Ruderman]

Attachment: testcase

This testcase contains a copy of 
http://savorysweetlife.com/wp-content/plugins/favicon-generator/favicon.ico

###!!! ASSERTION: invalid image width: 'aWidth > 0', file modules/libpr0n/src/imgFrame.cpp, line 78

###!!! ASSERTION: invalid image height: 'aHeight > 0', file modules/libpr0n/src/imgFrame.cpp, line 79

###!!! ASSERTION: width less than zero: 'result >= 0', file layout/base/nsLayoutUtils.cpp, line 2112

###!!! ASSERTION: Intrinsic ratio has a negative component!: 'aIntrinsicRatio.width >= 0 && aIntrinsicRatio.height >= 0', file layout/base/nsLayoutUtils.cpp, line 2308

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Maybe fixed by the patch in bug 516665?

Comment 3

[Jesse Ruderman]

No, still happens with that patch.

Comment 4

[Jesse Ruderman]

Now I just get

###!!! ASSERTION: invalid image width: 'aWidth > 0', file /builds/slave/mozilla-central-macosx64-debug/build/modules/libpr0n/src/imgFrame.cpp, line 78
###!!! ASSERTION: invalid image height: 'aHeight > 0', file /builds/slave/mozilla-central-macosx64-debug/build/modules/libpr0n/src/imgFrame.cpp, line 79

which is an improvement.

Comment 5

[Brian R. Bondy [:bbondy]]

The remaining assertions mentioned in Comment 4 were fixed as a side effect of this push a couple months ago (Bug 619048 http://hg.mozilla.org/mozilla-central/rev/17f5ec50a7f1) to mozilla-central.