522214 - Crash when setting null on charset [@ strlen | nsDependentCString::nsDependentCString(char const*)]

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase (uses enhanced privileges)

See testcase.

http://crash-stats.mozilla.com/report/index/6f0017d5-0117-41f4-90bb-ab7542091014?p=1
0  	mozcrt19.dll  	strlen  	strlen.asm:81
1 	xul.dll 	nsDependentCString::nsDependentCString 	obj-firefox/dist/include/nsTDependentString.h:90
2 	xul.dll 	nsDocShell::SetCharset 	docshell/base/nsDocShell.cpp:1745
3 	xul.dll 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
4 	xul.dll 	XPCWrappedNative::CallMethod 	js/src/xpconnect/src/xpcwrappednative.cpp:2710

Comment 1

[timeless]

Attachment: handle null pointers

i believe there are a couple of instances in this file.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 411573 [details] [diff] [review]
handle null pointers

>+        nsCString charset;
>+        if (aCharset)
>+          charset = nsDependentCString(aCharset);

That pattern is silly..  Just do |nsCString charset(aCharset)|.  Or better yet throw up front on null.

Same for the other hunk that does this.

>-        mGlobalHistory->SetPageTitle(mCurrentURI, nsDependentString(aTitle));
>+        mGlobalHistory->SetPageTitle(mCurrentURI, mTitle);

Technically not the same, since SetTitle can reenter... not that it handles that anyway, so this is fine.

Add a test?

Comment 3

[timeless]

Attachment: skip Dependent's

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 429420 [details] [diff] [review]
skip Dependent's

r=bzbarsky

Comment 5

[timeless]

http://hg.mozilla.org/mozilla-central/rev/6447c15170c6