Closed Bug 522261 Opened 10 years ago Closed 10 years ago

Some code is firing after the browser window closes

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
When the browser window closes we can still have code firing, trying to call other code, which fails:

* Console error observer
* Idle service observer

We could add an uninit to the ConsoleView and remove the observer completely. What do you think?
Attachment #406231 - Flags: review?(gavin.sharp)
Comment on attachment 406231 [details] [diff] [review]
patch

(In reply to comment #0)
> We could add an uninit to the ConsoleView and remove the observer completely.
> What do you think?

I think I'd prefer that...
Attachment #406231 - Flags: review?(gavin.sharp) → review+
changed to uninit with explicit unregister
pushed:
https://hg.mozilla.org/mobile-browser/rev/54ce9a5b1671
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
bugspam
Assignee: nobody → mark.finkle
You need to log in before you can comment on or make changes to this bug.