Closed
Bug 522292
Opened 15 years ago
Closed 15 years ago
Make the character properties table in nsCSSScanner a compile time constant
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: zwol, Assigned: zwol)
Details
Attachments
(1 file, 1 obsolete file)
|
5.26 KB,
patch
|
zwol
:
review+
|
Details | Diff | Splinter Review |
The patch I'm about to attach turns the character properties table in nsCSSScanner.cpp [that is, gLexTable] into a compile-time constant.
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #406247 -
Flags: review?(dbaron)
Comment on attachment 406247 [details] [diff] [review]
patch
r=dbaron
Attachment #406247 -
Flags: review?(dbaron) → review+
(You should at least make sure try server is ok with your single letter constants; you could get in trouble if something else defines those.)
|
|
Assignee | |
Comment 4•15 years ago
|
||
I just pushed my entire current stack of scanner changes to the try server, will report.
|
|
Assignee | |
Comment 5•15 years ago
|
||
The tree is little shaky right now, but I don't think any of the failures are my fault. Unit test logs:
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1255547096.1255558618.32645.gz
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1255547096.1255557279.17947.gz
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1255547096.1255558069.26453.gz
|
|
Assignee | |
Comment 6•15 years ago
|
||
Rediffed to eliminate a textual dependency on bug 516091.
Pushed http://hg.mozilla.org/mozilla-central/rev/89e096ecc268
Attachment #406247 -
Attachment is obsolete: true
Attachment #406519 -
Flags: review+
|
|
Assignee | |
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•