Closed Bug 522292 Opened 13 years ago Closed 13 years ago

Make the character properties table in nsCSSScanner a compile time constant

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: zwol, Assigned: zwol)

Details

Attachments

(1 file, 1 obsolete file)

The patch I'm about to attach turns the character properties table in nsCSSScanner.cpp [that is, gLexTable] into a compile-time constant.
Attached patch patch (obsolete) — Splinter Review
Attachment #406247 - Flags: review?(dbaron)
Comment on attachment 406247 [details] [diff] [review]
patch

r=dbaron
Attachment #406247 - Flags: review?(dbaron) → review+
(You should at least make sure try server is ok with your single letter constants; you could get in trouble if something else defines those.)
I just pushed my entire current stack of scanner changes to the try server, will report.
Rediffed to eliminate a textual dependency on bug 516091.
Pushed http://hg.mozilla.org/mozilla-central/rev/89e096ecc268
Attachment #406247 - Attachment is obsolete: true
Attachment #406519 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.