522360 - [js-ctypes] Support opening of DLLs without full path using the system PATH

Status: RESOLVED FIXED

(Core :: js-ctypes, enhancement)

Description

[Daniel Kirsch]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091014 Minefield/3.7a1pre
Build Identifier: 

Most languages support linking to a DLL by just defining the DLL name. The DLL must then be in the system PATH (or in the same path of the executable).

Something similar should be supported for js-ctypes as well. At least the system PATH.

Reproducible: Always

Comment 1

[Makoto Kato [:m_kato]]

the search rule of loading DLL in Windows.
http://support.microsoft.com/kb/164501/

Comment 2

[[e-mail]]

Does PR_LoadLibrary follow any of the platform-specific search rules (via the OS hooks it uses)? Or do we have to implement it all ourselves?

Comment 3

[Makoto Kato [:m_kato]]

(In reply to comment #2)
> Does PR_LoadLibrary follow any of the platform-specific search rules (via the
> OS hooks it uses)? Or do we have to implement it all ourselves?

Dan, I believe that InitWithPath returns error at first.

Comment 4

[Makoto Kato [:m_kato]]

confirmed on Linux x86 and Windows x86.  Maybe, I think that we should use LoadLibraryWithFlags instead of nsILocalFile::Load() since InitWithPath() returns error.

Comment 5

[Makoto Kato [:m_kato]]

Attachment: patch v1

Comment 6

[[e-mail]]

Comment on attachment 406662 [details] [diff] [review]
patch v1

Wonderful. r=me! Does this pass tryserver on all platforms?

Comment 7

[Makoto Kato [:m_kato]]

(In reply to comment #6)
> (From update of attachment 406662 [details] [diff] [review])
> Wonderful. r=me! Does this pass tryserver on all platforms?

Yes.

Comment 8

[Makoto Kato [:m_kato]]

landed
http://hg.mozilla.org/mozilla-central/rev/e00dfdccc270

Comment 9

[Daniel Kirsch]

Dan, Makoto, thanks again for your great and really fast work. Nice job!

Comment 10

[Makoto Kato [:m_kato]]

landed to 1.9.2
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/37ae16d4083e