522413 - NJ merge: remove uses of static avmcore::config

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Graydon Hoare :graydon]

Attachment: chop chop

Tamarin doesn't have a static avmcore object. We gotta get rid of this stuff.

(Also picked up one more of those unused parameters in x86).

Comment 1

[Rick Reitmaier]

NJ_SOFTFLOAT implies ARM_VFP == 0, no?

But in any case, ARM_VFP should not leak out into LIR.cpp

Comment 2

[Graydon Hoare :graydon]

No. NJ_SOFTFLOAT means that we conditionally compiled-in softfloat support. Which we always do in the TM embedding. ARM_VFP is dynamically detected at startup. It may be true or false, it's a runtime test.

I'd like to prevent ARM_VFP from leaking into LIR.cpp as well, but I don't know how else to manage this without just making a different runtime name for exactly the same thing. I think that can wait for a later patch. This gets us to "merged".

Comment 3

[Andreas Gal :gal]

Comment on attachment 406380 [details] [diff] [review]
chop chop

AvmPlus is "ActionScript" something. Can we please not have that in our source base? + to push ahead with merge but please fix along the way later.

Comment 4

[Graydon Hoare :graydon]

There are 108 references to AVM in nanojit.  There are also 3 references to MOZ-qualified symbols, and a whole lot of talk of the mozilla public license.

If you really want to excise all AVM stuff, that's a longer-term project.

Comment 5

[Graydon Hoare :graydon]

http://hg.mozilla.org/tracemonkey/rev/09a701210197

Comment 6

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/09a701210197