522438 - Dragging a second history item to toolbar does not work

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Ria Klaassen (not reading all bugmail)]

STR:

- Create new profile
- Open 3 Latest Headlines items
- Open history sidebar
- Drag the first item to the personal toolbar
- Drag a second item

Result: not possible. Sometimes, if you try long enough, it will succeed. 

Regression range is http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=979c128d2e63&tochange=11a1ae54a32c

My guess is Bug 458043 but there are more candidates. Please remove/replace if not correct.

I see also interesting behavior in the sidebar if I try to delete the only successfully dragged item. The first time the deletion will not succeed. The second time it both deletes the toolbar item and the not successfully dragged item in the sidebar.  

Also present in Namoroko.

Comment 1

[Ria Klaassen (not reading all bugmail)]

> if I try to delete the only successfully dragged item.

Correction: if I try to delete the only successfully dragged toolbar item.

Comment 2

[Ria Klaassen (not reading all bugmail)]

> Sometimes, if you try long enough, it will succeed. 

After clicking on the failing history item so that it loads. But then still the first drag attempt (after loading the site) will not work, but the second attempt will.

Comment 3

[Marco Bonardo [:mak]]

the regressing bug looks wrong, that bug changed editBookmarkOverlay that is not involved in any of the steps

Comment 4

[Ria Klaassen (not reading all bugmail)]

Is also in Shiretoko so not a blocker probably.

Comment 5

[Marco Bonardo [:mak]]

no, if it's not a new namoroka regression no way to prioritize it to blocker. it's annoying but not blocking a release.

could be Bug 398928 - Allow moving a window by dragging toolbar or statusbar

but even that is strange. i can't find other possible culprits if the range is correct.

Comment 6

[Ria Klaassen (not reading all bugmail)]

Does this bug stil need additional info Marco? I could only offer rough random checks for a possible culprit as a quick service but there are way better tools. I have time nor interest to download Mercurial and start bisecting.

Comment 7

[Marco Bonardo [:mak]]

i think there's enough, we need to debug the thing, the fact nobody filed a bug for 3.5 till now shows that's a minor problem

Comment 8

[Ria Klaassen (not reading all bugmail)]

Yes. I would never have discovered it myself. I saw this while testing another issue.

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 10

[Marco Bonardo [:mak]]

cannot reproduce