Closed
Bug 522440
Opened 15 years ago
Closed 15 years ago
QCMS: Make sse/sse2 code built with Sun Studio 12 on Solaris
Categories
(Core :: Graphics: Color Management, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
References
Details
Attachments
(2 files)
|
3.14 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
|
1.75 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
We need some work to make it work with SS12. 1) Modify #ifdef to build cpuid() 2) Modify Makefile.in to add proper flags for sse/sse2 3) Strip hwcap on linking 4) Check if we need another fix for __force_align_arg_pointer__ or we can just disable it at this time. BTW: Do we have perf test for QCMS?
Patch for task 1) 2). Task 4) is not required, I think. I don't have crashes so far. Task 3) requires a change in rules.mk and add a ld map file for Solaris x86 with Sun Studio compiler. I'll attach the patch after I commit another change to rules.mk.
Attachment #407975 -
Flags: review?(jmuizelaar)
|
||
Updated•15 years ago
|
Attachment #407975 -
Flags: review?(jmuizelaar) → review+
Strip MMX, SSE, SSE2 flags from HWCAP. So the library/executable can be loaded on a machine without MMX/SSE/SSE2 support. No need for gcc/Solaris, it doesn't generate HWCAP.
Attachment #408334 -
Flags: review?(benjamin)
|
||
Updated•15 years ago
|
Attachment #408334 -
Flags: review?(benjamin) → review?(ted.mielczarek)
|
||
Updated•15 years ago
|
Attachment #408334 -
Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/7e5d6d6bef82
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
Blocks: C192ConfSync
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.3a1
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•