522472 - Regression : adding more than 4 tabs mess up the tab bar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Fabrice Desré]

Attachment: screenshot

All tabs are in a single column vbox, thus being pushed out of screen when more than 4 are displayed.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

It came from the resolution of bug 520913.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Just a little bit of explanation here:
for aligning the tabs moz-column is used and it needs to know a maximum height for it vertical expansion. That's the role of the resize method. We want the tab box to update their available height when the window is resize, in order to fit the tabs on the available height.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

I can land this, but I'd like some tests added to browser_tabs.js to verify:

* More than 5 tabs creates a new column
* Removing a 5th tab makes the extra column go away

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/82a4e54c8be8

Comment 5

[Aakash Desai [:aakashd]]

This needs to be re-opened as this is happening on 1.9.2 branch and trunk winmo builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2b1pre) Gecko/20091016 Fennec/1.0a4pre

and

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20091016 Fennec/1.0a4pre

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Actually, that sounds like bug 518370, not this one. Sorry for pointing you at the wrong bug.

Comment 7

[Aakash Desai [:aakashd]]

Ah, gotcha. Either way, this bug was verified as well :)

Comment 8

[Aakash Desai [:aakashd]]

litmus testcase needs to be changed to account for 4 tabs in maemo devices (n810 and n900) currently via landscape mode.

Comment 9

[Al Billings [:abillings - ex-MoCo]]

Added this bug to an existing testcase for tab thumbnails: https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=9766

in-litmus+