Closed Bug 522472 Opened 13 years ago Closed 13 years ago

Regression : adding more than 4 tabs mess up the tab bar

Categories

(Firefox for Android Graveyard :: General, defect)

Fennec 1.1
x86
All
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
fennec1.0b5

People

(Reporter: fabrice.desre, Assigned: vingtetun)

Details

Attachments

(2 files)

Attached image screenshot
All tabs are in a single column vbox, thus being pushed out of screen when more than 4 are displayed.
Attached patch PatchSplinter Review
It came from the resolution of bug 520913.
Attachment #406457 - Flags: review?
Just a little bit of explanation here:
for aligning the tabs moz-column is used and it needs to know a maximum height for it vertical expansion. That's the role of the resize method. We want the tab box to update their available height when the window is resize, in order to fit the tabs on the available height.
Attachment #406457 - Flags: review?(webapps) → review+
I can land this, but I'd like some tests added to browser_tabs.js to verify:

* More than 5 tabs creates a new column
* Removing a 5th tab makes the extra column go away
Assignee: nobody → fabrice.desre
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → B5
This needs to be re-opened as this is happening on 1.9.2 branch and trunk winmo builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2b1pre) Gecko/20091016 Fennec/1.0a4pre

and

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20091016 Fennec/1.0a4pre
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Actually, that sounds like bug 518370, not this one. Sorry for pointing you at the wrong bug.
Status: REOPENED → RESOLVED
Closed: 13 years ago13 years ago
Resolution: --- → FIXED
Ah, gotcha. Either way, this bug was verified as well :)
Status: RESOLVED → VERIFIED
litmus testcase needs to be changed to account for 4 tabs in maemo devices (n810 and n900) currently via landscape mode.
Flags: in-litmus?
Added this bug to an existing testcase for tab thumbnails: https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=9766

in-litmus+
Flags: in-litmus? → in-litmus+
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.