522510 - Add "deprecated" comments to key.h and pk11func.h

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Wan-Teh Chang]

Attachment: Proposed patch

The patch adds comments to key.h and pk11func.h to
note that these headers are deprecated and replaced
by keyhi.h and pk11pub.h, respectively.

I considered fixing NSS itself to use the new headers,
but found that there are too many files to fix:

http://mxr.mozilla.org/security/search?string=%22key.h%22
http://mxr.mozilla.org/security/search?string=%3Ckey.h%3E

http://mxr.mozilla.org/security/search?string=%22pk11func.h%22
http://mxr.mozilla.org/security/search?string=%3Cpk11func.h%3E

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 406476 [details] [diff] [review]
Proposed patch

r=nelson

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Although this bug requests a change to a comment in the code, 
I disagree that it is a documentation bug.  Changing component to libraries.

Comment 3

[Wan-Teh Chang]

I checked in the patch on the NSS trunk (NSS 3.12.5).

Checking in lib/cryptohi/key.h;
/cvsroot/mozilla/security/nss/lib/cryptohi/key.h,v  <--  key.h
new revision: 1.5; previous revision: 1.4
done
Checking in lib/pk11wrap/pk11func.h;
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11func.h,v  <--  pk11func.h
new revision: 1.55; previous revision: 1.54
done

Comment 4

[Robert Relyea]

Comment on attachment 406476 [details] [diff] [review]
Proposed patch

sr+ relyea