Add "deprecated" comments to key.h and pk11func.h

RESOLVED FIXED in 3.12.5

Status

--
trivial
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: wtc, Assigned: wtc)

Tracking

3.12
3.12.5

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 406476 [details] [diff] [review]
Proposed patch

The patch adds comments to key.h and pk11func.h to
note that these headers are deprecated and replaced
by keyhi.h and pk11pub.h, respectively.

I considered fixing NSS itself to use the new headers,
but found that there are too many files to fix:

http://mxr.mozilla.org/security/search?string=%22key.h%22
http://mxr.mozilla.org/security/search?string=%3Ckey.h%3E

http://mxr.mozilla.org/security/search?string=%22pk11func.h%22
http://mxr.mozilla.org/security/search?string=%3Cpk11func.h%3E
Attachment #406476 - Flags: superreview?(rrelyea)
Attachment #406476 - Flags: review?(nelson)
Attachment #406476 - Flags: review?(nelson) → review+
Comment on attachment 406476 [details] [diff] [review]
Proposed patch

r=nelson
Although this bug requests a change to a comment in the code, 
I disagree that it is a documentation bug.  Changing component to libraries.
Component: Documentation → Libraries
QA Contact: documentation → libraries
(Assignee)

Comment 3

9 years ago
I checked in the patch on the NSS trunk (NSS 3.12.5).

Checking in lib/cryptohi/key.h;
/cvsroot/mozilla/security/nss/lib/cryptohi/key.h,v  <--  key.h
new revision: 1.5; previous revision: 1.4
done
Checking in lib/pk11wrap/pk11func.h;
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11func.h,v  <--  pk11func.h
new revision: 1.55; previous revision: 1.54
done
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Comment 4

9 years ago
Comment on attachment 406476 [details] [diff] [review]
Proposed patch

sr+ relyea
Attachment #406476 - Flags: superreview?(rrelyea) → superreview+
You need to log in before you can comment on or make changes to this bug.