522517 - Panning sometimes causes link clicks

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect, P1)

Description

[Benjamin Stover (:stechz)]

Try going to news.google.com and panning for a while on the N900.  Occasionally you will discover you have clicked a link.

Comment 1

[Madhava Enros [:madhava]]

and/or focus fields

Comment 2

[Benjamin Stover (:stechz)]

Attachment: Patch

It was lockAxis's fault.  On mouseup, if not enough time has expired, a click would *always* happen because lockAxis would return the drag start position.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 408079 [details] [diff] [review]
Patch

To test it you can go to news.google.com and tries to pan a lot quickly.
Before the patch some accidental click happened (especially during kinetic scrolling)

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/b224b864866d

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED on builds (pan down a bit, stop on a link while still in mousedown, wait 1-2 seconds and mouseup...no click):

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091026
Fennec/1.0b5pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20091026
Fennec/1.0b5pre


I think we should incorporate this into our litmus testsuite under the screen navigation BFT

Comment 6

[Al Billings [:abillings - ex-MoCo]]

Added to screen navigation BFTs: https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=9829