Closed Bug 522583 Opened 15 years ago Closed 15 years ago

nsUpdateService.js.in cleanup (remove previous update migration code, defineLazyServiceGetter for nsIObserverService, and other cleanup)

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
status1.9.2 --- beta2-fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

(Whiteboard: [code cleanup])

Attachments

(1 file, 2 obsolete files)

patch rev1
17.27 KB, patch
mossop
: review+
beltzner
: approval1.9.2+
Details | Diff | Splinter Review 
Before refactoring nsUpdateService.js.in there is additional cleanup I'd like to do first.
Attached patch patch in progress rev1 (obsolete) — — Splinter Review 
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED

    
    

    
  
Likely needs the patch from bug 521452 so adding dependency
Depends on: 521452
Whiteboard: [code cleanup]

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch in progress rev2 (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #406548 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch rev1
        — 
          — Splinter Review
      

    


  

        Attachment #406649 -
        Attachment is obsolete: true

        Attachment #407844 -
        Attachment description: patch in progress rev3 → patch rev1

        Attachment #407844 -
        Flags: review?(dtownsend)

        Attachment #407844 -
        Flags: review?(dtownsend) → review+

    
    

    
  
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/fdeaaf29f021
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 407844 [details] [diff] [review]
patch rev1

Drivers, this is part of the work heading up to fixing bug 311965 which should improve TS on fennec and Firefox WinCE... possibly a few ms on desktop as well.

        Attachment #407844 -
        Flags: approval1.9.2?

    
    

    
  
Comment on attachment 407844 [details] [diff] [review]
patch rev1

a192=beltzner

        Attachment #407844 -
        Flags: approval1.9.2? → approval1.9.2+

    
    

    
  
Pushed to mozilla-1.9.2
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/9ceaf30df15f

Adding in-testsuite+ since this code is heavily exercised by both app update xpcshell tests

          status1.9.2:
          --- → final-fixed
Flags: in-testsuite+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: