522605 - [AMO] Review count mismatch between details and reviews page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P5)

Description

[Vishal Kamdar [:vish_moz]]

Addons details page for this addon https://preview.addons.mozilla.org/en-US/firefox/addon/1865 shows 1379 reviews
whereas
https://preview.addons.mozilla.org/en-US/firefox/reviews/display/1865 shows 1294

Comment 1

[krupa raj[:krupa]]

 regression of https://bugzilla.mozilla.org/show_bug.cgi?id=428118

Comment 2

[Alfred Kayser]

Smaller example is as follows:
https://addons.mozilla.org/en-US/seamonkey/search?q=littlemonkey&cat=all
Showing 4 reviews

https://addons.mozilla.org/en-US/seamonkey/addon/309
Showing 3 reviews

https://addons.mozilla.org/en-US/seamonkey/reviews/display/309
Only has 2 reviews

Comment 3

[Tobias (:Tobbi) Markus]

This is also the case with Minimap sidebar:

https://preview.addons.mozilla.org/en-US/firefox/addon/5203
Showing 67 reviews

https://preview.addons.mozilla.org/en-US/firefox/reviews/display/5203
Showing 66 reviews

Comment 4

[Pratibha]

Reviews count is mismatched:
https://preview.addons.mozilla.org/en-US/firefox/addon/3615#reviews
showing 401 reviews

https://preview.addons.mozilla.org/en-US/firefox/reviews/display/3615
showing 387 reviews

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

I'm noticing this in Zamboni, too, but it's much worse there.

STR:

1. Load https://preview.addons.mozilla.org/z/en-US/firefox/addon/10218/#reviews
2. Look at the link that says "See all 3 reviews of this add-on >"
3. Click it
4. You're taken to https://preview.addons.mozilla.org/z/en-US/firefox/addon/10218/reviews/
5. Look at the # of results at the bottom

Shouldn't this be 5.9, given that we're doing details pages in Zamboni in 5.9?

Comment 7

[Jeff Balogh (:jbalogh)]

I'm going to call this fixed by switching to a zamboni cronjob in http://github.com/jbalogh/zamboni/commit/2c4525a7 and http://github.com/jbalogh/zamboni/commits/7949674.

/reviews will still be remora, so it may not match there, but /z/reviews should be consistent.

Comment 8

[Vishal Kamdar [:vish_moz]]

Verified, FIXED.

Comment 9

[Jeff Balogh (:jbalogh)]

(In reply to comment #8)
> Verified, FIXED.

Not on https://preview.addons.mozilla.org/z/en-US/firefox/addon/6028/, the cronjob hasn't run yet.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Vishal, please verify this; thanks!

Comment 11

[Vishal Kamdar [:vish_moz]]

This addon https://preview.addons.mozilla.org/z/en-US/firefox/addon/6028/
has 3 reviews but it says 0 reviews. (Not reopening because not sure if the cron job needs to run)

Comment 12

[Pratibha]

This addon  https://next.addons.mozilla.org/en-US/firefox/addon/6028/  has
 0 reviews,   but clicking on the link                    https://next.addons.mozilla.org/en-US/firefox/reviews/display/6028  shows 3 reviews

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED:

In Zamboni, https://preview.addons.mozilla.org/z/en-US/firefox/addon/1865/reviews/ has 1,851 reviews listed, which matches its details page https://preview.addons.mozilla.org/en-US/firefox/addon/1865/, while Remora still has 1,712 reviews: https://preview.addons.mozilla.org/en-US/firefox/reviews/display/1865