522621 - Clean up wrapper code

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v.5

Goals:
  * Use namespaces instead of C-like UGLY_PREFIXES_blah to separate different wrappers' functions.
  * Centralize common declarations.
  * Get rid of macros in favor of typesafe inline functions.

This patch isn't quite ready. I need to move some functions around to consolidate namespace declarations.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v1

This consolidates the namespace definitions in the individual files. I'll pass this through the try server before checking in. One thing that sicking pointed out was that I'm not putting my stuff in namespace mozilla {}. I don't know if this matters. I don't see the use of namespace mozilla here because none of this stuff is exported past nsIXPConnect. I can add in namespace mozilla{} (and using declarations) if people really care *that much*.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

jst, this patch passes the try server.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 407387 [details] [diff] [review]
patch v1

r=jst for this hygiene enhancer :)

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/e85afc5f51b1