522769 - XUL tree widget can call tree view setCellText multiple times

Status: RESOLVED FIXED

(Toolkit :: XUL Widgets, defect)

Description

[Erik Staats]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.14) Gecko/2009082706 Firefox/3.0.14
Build Identifier: Songbird 1.5.0a build 1321

In the XUL tree widget stopEditing method, stopEditing may be reentered via the call to setCellText.  Since this._editingColumn is not cleared until after stopEditing is called, stopEditing can be called a second time.

In the case of the Songbird filter pane widget's use of the XUL tree widget, setCellText sends a request to a thread and waits for the result, processing the event queue in the meantime.  Another UI event is on the queue that causes stopEditing to be called again.

If the text change causes a change in the filter results, the tree rows will change and the second call to setCellText will target the incorrect item.  However, it shouldn't be called a second time.


Reproducible: Sometimes

Steps to Reproduce:
STR
1) Launch Songbird 1.5 build 1321.
2) Import music from multiple artists.
3) Select one of the artists in the artist filter pane.
4) Change the artist name in one of the tracks.


Actual Results:  
Artist name changed in selected track plus an additional track from different
artist.


Expected Results:  
Artist name changed in only one track.


See http://bugzilla.songbirdnest.com/show_bug.cgi?id=18399

Comment 1

[Erik Staats]

Attachment: Changed the XUL tree widget to clear _editingColumn before calling setCellText in stopEditing.

Comment 2

[Erik Staats]

Attachment: Changed the XUL tree widget to clear _editingColumn before calling setCellText in stopEditing.

Comment 3

[Erik Staats]

Comment on attachment 406746 [details] [diff] [review]
Changed the XUL tree widget to clear _editingColumn before calling setCellText in stopEditing.

Per Mook's suggestion.

Comment 4

[Erik Staats]

Comment on attachment 406746 [details] [diff] [review]
Changed the XUL tree widget to clear _editingColumn before calling setCellText in stopEditing.

Songbird is looking to migrate to the 1.9.2 branch from 1.9.0 and would like to not have to maintain this patch locally

Comment 5

[Wladimir Palant]

This can already land on trunk however.

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/64994a873a48

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 406746 [details] [diff] [review]
Changed the XUL tree widget to clear _editingColumn before calling setCellText in stopEditing.

approval1.9.2 requests aren't currently being monitored, since we're nearing RC freeze and there are too many outstanding requests, so I'm clearing this request. Feel free to re-request approval if you are confident that it's worth drivers' time to consider whether this non-blocker needs to land for 1.9.2 at this stage.