310.85 KB, image/png
268.59 KB, image/png
95.49 KB, image/png
1.50 KB, patch
|Details | Diff | Splinter Review|
A user in Live Chat is reporting that showfor content for all operating systems is appearing on IE7, rather than hiding content for other systems. Searching through chat logs, there seem to be a number of other cases where Windows users are confused about Mac instructions in the middle of articles. SUMO should be fully functional in all versions of IE >=7, and basic functionality should work in IE6. Could we test to make sure this wasn't regressed?
In IE 8, and IE 8's IE 7 mode, it works for me. Stephen or Vishal, can you verify this in a real IE 7 installation?
This works for me in a "native" IE 7 build (that is, IE 7 in Windows XP in a VM).
I can confirm this, actually, now that I know what I'm looking for (thx, zzxc). I'll upload a screenshot that shows the problem (look for the |Option| key reference, and others (that are Mac-specific).
Created attachment 406793 [details] Screenshot showing the mixed-platform content (reference to the "Option" key for Windows)
Just to clarify (and remind myself) this does occur in IE 8 when in IE 7 mode, now that I know exactly what to look for. Does SHOWFOR have special markup for lists?
Assignee: nobody → james
Target Milestone: --- → 1.4.2
Testcase for this specific bug up at https://litmus.mozilla.org/show_test.cgi?id=9587 (we can change the testcase to test IE 6 and IE 8 too).
Assignee: james → paulc
Priority: -- → P1
Attachment #408138 - Flags: review?(james)
Comment on attachment 408138 [details] [diff] [review] v1 It hid all options, instead of none of them. (Will include screenshot.)
Attachment #408138 - Flags: review?(james) → review-
Created attachment 408496 [details] screenshot (Technically, this is IE 8 in IE 7 mode, but it matches what I saw in IE 7. I just couldn't easily get a screenshot from the IE 7 VM [no print screen key]).)
Created attachment 409141 [details] [diff] [review] v2 setAttribute('style','...'); does not work in IE < 8. There were also some issues with using String.match()--I replaced strings with RegExps--and there was a variable being redeclared incessantly. I also reversed the order of the for loop to prevent repeated calls to NodeList.length. Tested in: WinXP: - IE 6 - IE 7 - IE 8 - Firefox 3.5 - Chrome MacOS - Firefox 3.5 - Safari
Comment on attachment 409141 [details] [diff] [review] v2 Looks good on IE6,7,8, Fx3.5.3, and Chrome 3.
Attachment #409141 - Flags: review?(paulc) → review+
I should add all of the above for WinXP. I also tested Linux Fx3.5.3.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Verified, FIXED. Verified on: Win XP: - IE 6 - IE 7 - Fx 3.5 Win Vista: - IE 8 Linux: - Fx 3.0
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.