Status

P5
minor
RESOLVED WONTFIX
9 years ago
3 years ago

People

(Reporter: leszekz, Assigned: clouserw)

Tracking

unspecified

Details

(Reporter)

Description

9 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3
Build Identifier: 

In the .po file is bad coded % sign in the phrase:
Of the %1$s add-ons that make up 95% of add-on usage known to Mozilla
Should be:
Of the %1$s add-ons that make up 95% of add-on usage known to Mozilla

Reproducible: Always
Using a double % (%%) should also work.

In general, we should run `msgfmt -c messages.po` to make sure the file is formatted correctly. I recently found a number of problems with the German file, most of which (but not all) I could fix.
(Reporter)

Comment 2

9 years ago
(In reply to comment #1)
> Using a double % (%%) should also work.
> 
> In general, we should run `msgfmt -c messages.po` to make sure the file is
> formatted correctly. I recently found a number of problems with the German
> file, most of which (but not all) I could fix.

For what use (%%) if in the same line is '<b>%2$s&#37;</b>'?
(Assignee)

Comment 3

9 years ago
The double percent is more correct in this context I think.  The string should be:

  Of the %1$s add-ons that make up 95%% of add-on usage known to Mozilla

I'll try to remember to fix this before we push live.
Assignee: nobody → clouserw
OS: Windows XP → All
Hardware: x86 → All
Target Milestone: --- → 5.5
(Assignee)

Updated

9 years ago
Severity: normal → minor
Priority: -- → P5
(Assignee)

Comment 4

9 years ago
So...why do we not want the % there?  Why should it be encoded to &#37;?
(Reporter)

Comment 5

9 years ago
(In reply to comment #4)
> So...why do we not want the % there?  Why should it be encoded to &#37;?

This is PHP standard.
(Assignee)

Comment 6

9 years ago
(In reply to comment #5)
> (In reply to comment #4)
> > So...why do we not want the % there?  Why should it be encoded to &#37;?
> 
> This is PHP standard.

It doesn't affect the output and PHP is going away.  ->wontfix
Status: UNCONFIRMED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → WONTFIX
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.