522810 - Bad coded % sign

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Localization, defect, P5)

Description

[Leszek Zyczkowski]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3
Build Identifier: 

In the .po file is bad coded % sign in the phrase:
Of the %1$s add-ons that make up 95% of add-on usage known to Mozilla
Should be:
Of the %1$s add-ons that make up 95% of add-on usage known to Mozilla

Reproducible: Always

Comment 1

[Fred Wenzel [:wenzel]]

Using a double % (%%) should also work.

In general, we should run `msgfmt -c messages.po` to make sure the file is formatted correctly. I recently found a number of problems with the German file, most of which (but not all) I could fix.

Comment 2

[Leszek Zyczkowski]

(In reply to comment #1)
> Using a double % (%%) should also work.
> 
> In general, we should run `msgfmt -c messages.po` to make sure the file is
> formatted correctly. I recently found a number of problems with the German
> file, most of which (but not all) I could fix.

For what use (%%) if in the same line is '<b>%2$s&#37;</b>'?

Comment 3

[Wil Clouser [:clouserw]]

The double percent is more correct in this context I think.  The string should be:

  Of the %1$s add-ons that make up 95%% of add-on usage known to Mozilla

I'll try to remember to fix this before we push live.

Comment 4

[Wil Clouser [:clouserw]]

So...why do we not want the % there?  Why should it be encoded to %?

Comment 5

[Leszek Zyczkowski]

(In reply to comment #4)
> So...why do we not want the % there?  Why should it be encoded to %?

This is PHP standard.

Comment 6

[Wil Clouser [:clouserw]]

(In reply to comment #5)
> (In reply to comment #4)
> > So...why do we not want the % there?  Why should it be encoded to %?
> 
> This is PHP standard.

It doesn't affect the output and PHP is going away.  ->wontfix