If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Customize dialog opens with buttons partially clipped

VERIFIED FIXED

Status

SeaMonkey
Sidebar
P2
major
VERIFIED FIXED
17 years ago
13 years ago

People

(Reporter: shrirang khanzode, Assigned: Paul Chen)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [rtm++][fix in hand]reviewed and approved)

Attachments

(3 attachments)

(Reporter)

Description

17 years ago
build:2000091208 m18

Launch the browser
Select 'Tabs|Customize Sidebar'
Observe that the dislog box opens up with the buttons on the right hand side 
clipped (UP ,DOWN).

Expected: buttons should appear wholly when dilaog is opened.

Updated

17 years ago
Keywords: rtm

Comment 1

17 years ago
Yeah, saw this the other night.  Looks like Hell too.

Matt, if you're swamped, pass this off to pchen.
Assignee: slamm → matt
Priority: P3 → P2
Whiteboard: [RTM NEED INFO]

Comment 2

17 years ago
can you take a look at this
Assignee: matt → pchen

Comment 3

17 years ago
Created attachment 16093 [details] [diff] [review]
Patch to fix this bug, tested on Mac OS with modern. Patch to xpfe/components/sidebar/resources/customize.xul

Updated

17 years ago
Keywords: patch

Comment 4

17 years ago
I forgot to mention - this dialog remembers its size, so to see this fix you must 
delete your profile each time, so you see the default size for the dialog.
Keywords: review

Comment 5

17 years ago
Oh I hust realised - my patch makes the window wider than 480...

Is this forbidden? Do we try to fit in 640x480?

Comment 6

17 years ago
DOH DOH DOH. Need to go to bed.

480 is the height! Idiot! Sorry for all the spam!

Comment 7

17 years ago
480 is still to large to fit on a 640x480 screen on most OSes, due to
taskbar/panel etc..

Comment 8

17 years ago
>480 is still to large to fit on a 640x480 screen on most OSes, due to
>taskbar/panel etc..

Yes, but I didn't alter the height, I altered  the width, which is now 500 which
is well within the 600 figure for the screen width.

I was just being dumb and sleepy.

Comment 9

17 years ago
> but I didn't alter the height

OK, but maybe you should.
(Assignee)

Comment 10

17 years ago
marking fix in hand, will try out patch by tomorrow (10/11)
Status: NEW → ASSIGNED
Whiteboard: [RTM NEED INFO] → [RTM NEED INFO][fix in hand]
(Assignee)

Comment 11

17 years ago
The increase in width to 600 helps, but still could be better. See if I can work
up some xul mojo to make it better.

Comment 12

17 years ago
We'll never get this approved at this stage.  Minus for N6 RTM.
Whiteboard: [RTM NEED INFO][fix in hand] → [rtm-][fix in hand]
Created attachment 17568 [details] [diff] [review]
Here's the best patch for this bug, tested in both skins.
actually, I suck. I was using an existing profile which had remembered larger 
window dimensions which led me to believe that this patch fixed the bug. Well, 
it doesn't, but I now have one that does (thanks to jag for the suggestion). 
Created attachment 17575 [details] [diff] [review]
a 1-line patch that fixes this bug (actually fixes, tested with new profiles)
Here's a description of what this patch does:

a call to 'sizeToContent()' (a method defined on 'window') is called from the 
load handler attached to the window. 

This function sizes the window to fit the content inside it. It is skin 
independant and ensures the window is big enough to hold the widgets inside. 

Comment 17

17 years ago
Make this "need info" now that we have the correct courtesy of "jag".
Whiteboard: [rtm-][fix in hand] → [rtm need info][fix in hand]

Comment 18

17 years ago
r=jag, I like it :-)
(Assignee)

Comment 19

17 years ago
got an sr=alecf
(Assignee)

Comment 20

17 years ago
Gramps just told me to rtm+ this bug while we just met in the stairway. That's
my story, and I'm sticking to it.
Whiteboard: [rtm need info][fix in hand] → [rtm+][fix in hand]reviewed and approved

Comment 21

17 years ago
rtm++
Whiteboard: [rtm+][fix in hand]reviewed and approved → [rtm++][fix in hand]reviewed and approved
(Assignee)

Comment 22

17 years ago
stick a fork in it, checked into branch and trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Reporter)

Updated

17 years ago
Keywords: vtrunk
(Reporter)

Comment 23

17 years ago
This has been verified on all branch builds(win,mac,linux). Customize dialog no 
longer appears clipped when opened. Adding :VTRUNK for verification on trunk 
builds.

Comment 24

17 years ago
Verified Fixed on Mozilla trunk builds classic and modern themes.  Dialog looks
good.
linux 102308 RedHat 6.2
win32 102304 NT 4
mac 102312 Mac OS9
Setting bug to Verified and removing vtrunk keyword
Status: RESOLVED → VERIFIED
Keywords: vtrunk
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.