Closed Bug 522948 Opened 15 years ago Closed 15 years ago

crash at shutdown with geo.enabled=false [@nsCOMArray_base::InsertObjectAt(nsISupports*, int)]

Categories

(Core :: DOM: Geolocation, defect)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1
Tracking Status
blocking2.0 --- alpha1+
status1.9.2 --- beta1-fixed

People

(Reporter: elmar.ludwig, Assigned: elmar.ludwig)

References

()

Details

(Keywords: crash, regression, verified1.9.2)

Crash Data

Attachments

(1 file)

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20091010 Minefield/3.7a1pre ID:20091010030715

Firefox crashes at shutdown if the preference "geo.enabled" is set to "false" and the user visited a site that tried to obtain location data. Clean profile, no extensions installed. Ria also mentioned that in bug 522938 comment #1.

Steps to reproduce:

1. set "geo.enabled" to "false" in about:config
2. visit http://benwerd.com/lab/geo.php
3. close the browser -> crash

Crash ID: bp-e3d3cd59-6a81-4f5f-8d87-fc8b52091018
Namoroka3.6b2pre crashes too,
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2b2pre) Gecko/20091018 Namoroka/3.6b2pre ID:20091018045138

http://crash-stats.mozilla.com/report/index/f91f27fb-2ea9-4aee-a874-a71732091018?p=1
http://crash-stats.mozilla.com/report/index/f5ab626f-a729-46af-9718-c4e452091018?p=1
blocking2.0: --- → ?
OS: Linux → All
Regression range:

firefox-3.7a1pre-2009-08-28-03: works
firefox-3.7a1pre-2009-08-29-03: crashes

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=72c1f97df4c6&tochange=80f4cdc242b9

-> bug 462192
Blocks: 462192
The patch in bug 462192 destroys the nsGeolocationService if "geo.enabled" is false. Yet the object is still registered as an observer for "quit-application", which causes the crash on shutdown.
Keywords: regression
Hardware: x86 → All
Attached patch WIP patchSplinter Review
work-in-progress patch, completely untested

Doug: Do you think this is the correct way to fix the crash?
Attachment #407965 - Flags: review?(doug.turner)
this looks like the right fix.  Can you test it?  If no, I can over the weekend or next week.
(In reply to comment #5)
> Can you test it? If no, I can over the weekend or next week.

Not before the end of next week. I'm currently on vacation and don't have a build environment on my laptop. If you can get to it before then, please do.
Attachment #407965 - Flags: review?(doug.turner) → review+
thanks for the patch; it worked fine.

http://hg.mozilla.org/mozilla-central/rev/bf5dcfce29d4
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Attachment #407965 - Flags: approval1.9.2?
Attachment #407965 - Flags: approval1.9.0.16?
Did you mean to ask for approval on the 1.9.1 branch? Afaik 1.9.0.x doesn't have geolocation support.
Comment on attachment 407965 [details] [diff] [review]
WIP patch

natch - thanks.
Attachment #407965 - Flags: approval1.9.0.16? → approval1.9.1.5?
Comment on attachment 407965 [details] [diff] [review]
WIP patch

a192=beltzner
Attachment #407965 - Flags: approval1.9.2? → approval1.9.2+
Assignee: nobody → elmar.ludwig
Keywords: checkin-needed
The 1.9.1 branch is not affected AFAICT (and the patch will not apply), as bug 462192 did not land there.
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.3a1
Comment on attachment 407965 [details] [diff] [review]
WIP patch

clearing approval request per last comment, re-request with an explanation if that's wrong.
Attachment #407965 - Flags: approval1.9.1.6?
Verified fixed on the 1.9.2 branch using  Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b6pre) Gecko/20100105 Namoroka/3.6b6pre. I verified using the STR in Comment 0. Adding keyword.
Keywords: verified1.9.2
Marking the 14 bugs that are both:
 * nominated for blocking1.9.3:?
 * fixed on the 1.9.2 branch (according to status1.9.2)
as blocking1.9.3:alpha1, so that we don't have to go through the nominations individually.  They're all fixed already (so there's no work to do), and being fixed on 1.9.2 means they probably do block 1.9.3.
blocking2.0: ? → alpha1
Crash Signature: [@nsCOMArray_base::InsertObjectAt(nsISupports*, int)]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: