522982 - [RTL] Fennec firstrun page should be displayed in RTL for some locales

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Tomer Cohen :tomer]

Attachment: quick fix

The about:firstrun in Fennec should be displayed in RTL for locales that need it. It appears that this file is missing the direction directive from the xhtml file. 

I'm attaching a patch which should solve this issue. The problem is it seems that something is wrong with my locale, as chrome://global/locale/global.dtd has locale.dir set to 'ltr' even as the Hebrew locale explicitly sets dom/chrome/global.dtd to 'rtl'. (see also bug 522980)

Comment 1

[Murali Nandigama [:murali]]

These bugs do not have a specific reviewer assigned to them and are in 'review?' state. Kindly assign a specific reviewer.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 406946 [details] [diff] [review]
quick fix

Just want gavin to be aware of this sooner than later. I think there is a new firstrun page in the works

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 406946 [details] [diff] [review]
quick fix

This if fine, but as you point out, this is unlikely to make a difference until bug 522980 is fixed...

Comment 4

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mobile-browser/rev/3c8d53f687ab