Closed Bug 522982 Opened 14 years ago Closed 14 years ago

[RTL] Fennec firstrun page should be displayed in RTL for some locales

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Version:
Fennec 1.1
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
fennec1.0b5

People

(Reporter: tomer, Assigned: tomer)

Details

(Keywords: rtl)

Attachments

(1 file)

quick fix
741 bytes, patch
mfinkle
: review+
Gavin
: review+
Details | Diff | Splinter Review
Attached patch quick fix — — Splinter Review 
The about:firstrun in Fennec should be displayed in RTL for locales that need it. It appears that this file is missing the direction directive from the xhtml file. 

I'm attaching a patch which should solve this issue. The problem is it seems that something is wrong with my locale, as chrome://global/locale/global.dtd has locale.dir set to 'ltr' even as the Hebrew locale explicitly sets dom/chrome/global.dtd to 'rtl'. (see also bug 522980)
Attachment #406946 - Flags: review?
These bugs do not have a specific reviewer assigned to them and are in 'review?' state. Kindly assign a specific reviewer.
Attachment #406946 - Flags: review? → review?(mark.finkle)
Attachment #406946 - Flags: review?(mark.finkle)
Attachment #406946 - Flags: review?(gavin.sharp)
Attachment #406946 - Flags: review+
Comment on attachment 406946 [details] [diff] [review]
quick fix

Just want gavin to be aware of this sooner than later. I think there is a new firstrun page in the works
Comment on attachment 406946 [details] [diff] [review]
quick fix

This if fine, but as you point out, this is unlikely to make a difference until bug 522980 is fixed...
Attachment #406946 - Flags: review?(gavin.sharp) → review+
https://hg.mozilla.org/mobile-browser/rev/3c8d53f687ab
Assignee: nobody → tomer
Status: NEW → RESOLVED
Closed: 14 years ago
OS: Linux → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → B5
Summary: Fennec firstrun page should be displayed in RTL for some locales → [RTL] Fennec firstrun page should be displayed in RTL for some locales
You need to log in before you can comment on or make changes to this bug.