523063 - not able to add a bookmark

Status: RESOLVED DUPLICATE of bug 516667

(Firefox :: Bookmarks & History, defect)

Description

[Sangeeth]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.14) Gecko/2009090216 Ubuntu/8.10 (intrepid) Firefox/3.0.14
Build Identifier: Mozilla/5.0 (X11; U; AIX 5.3; en-US; rv:1.9.0.7) Gecko/2009101618 Firefox/3.0.7

when I click "Bookmarks"->"Bookmark This Page" in a 64 bit build no bookmark is added and ..
I get the following error in the ErrorConsole :

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsITransactionManager.doTransaction]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: file:///usr/mozilla/firefox/components/nsPlacesTransactionsService.js :: doTransaction :: line 194"  data: no]


On a 32 bit build when I click "Bookmarks"->"Bookmark This Page" the browser crashes for a 32 bit build.
with the following stack trace :
Illegal instruction in . at 0x0 ($t1)
0x00000000 00000000       Invalid opcode.
(dbx) t
.() at 0x0
nsCOMPtr.operator()(const nsID&,void**) const(this = 0x2ff1f688, aIID = &(...), answer = 0x2ff1f65c), line 47 in "nsCOMPtr.cpp"
nsBrowserApp.nsCOMPtr_base::assign_from_qi(nsQueryInterface,const nsID&)(this = 0x2ff1f724, qi = (...), iid = &(...)), line 96 in "nsCOMPtr.cpp"
xpcconvert.nsCOMPtr(nsQueryInterface)(0x2ff1f724, 0x2), line 645 in "nsCOMPtr.h"
unnamed block in XPCConvert::NativeData2JS(XPCCallContext&,long*,const void*,const nsXPTType&,const nsID*,JSObject*,unsigned int*)(ccx = &(...), d = 0x2ff1fa20, s = 0x2ff1fc1c, type = &(...), iid = 0x2ff1f874, scope = 0x209dc800, pErr = (nil)), line 465 in "xpcconvert.cpp"
unnamed block in XPCConvert::NativeData2JS(XPCCallContext&,long*,const void*,const nsXPTType&,const nsID*,JSObject*,unsigned int*)(ccx = &(...), d = 0x2ff1fa20, s = 0x2ff1fc1c, type = &(...), iid = 0x2ff1f874, scope = 0x209dc800, pErr = (nil)), line 465 in "xpcconvert.cpp"
unnamed block in XPCConvert::NativeData2JS(XPCCallContext&,long*,const void*,const nsXPTType&,const nsID*,JSObject*,unsigned int*)(ccx = &(...), d = 0x2ff1fa20, s = 0x2ff1fc1c, type = &(...), iid = 0x2ff1f874, scope = 0x209dc800, pErr = (nil)), line 465 in "xpcconvert.cpp"
XPCConvert::NativeData2JS(XPCCallContext&,long*,const void*,const nsXPTType&,const nsID*,JSObject*,unsigned int*)(ccx = &(...), d = 0x2ff1fa20, s = 0x2ff1fc1c, type = &(...), iid = 0x2ff1f874, scope = 0x209dc800, pErr = (nil)), line 465 in "xpcconvert.cpp"
unnamed block in CallMethod(nsXPCWrappedJS*,unsigned short,const XPTMethodDescriptor*,nsXPTCMiniVariant*)(this = 0x207a3e88, wrapper = 0x207a3f78, methodIndex = 21, info = 0x209e3d50, nativeParams = 0x2ff1fbec), line 1421 in "xpcwrappedjsclass.cpp"
unnamed block in CallMethod(nsXPCWrappedJS*,unsigned short,const XPTMethodDescriptor*,nsXPTCMiniVariant*)(this = 0x207a3e88, wrapper = 0x207a3f78, methodIndex = 21, info = 0x209e3d50, nativeParams = 0x2ff1fbec), line 1421 in "xpcwrappedjsclass.cpp"
CallMethod(nsXPCWrappedJS*,unsigned short,const XPTMethodDescriptor*,nsXPTCMiniVariant*)(this = 0x207a3e88, wrapper = 0x207a3f78, methodIndex = 21, info = 0x209e3d50, nativeParams = 0x2ff1fbec), line 1421 in "xpcwrappedjsclass.cpp"
CallMethod(unsigned short,const XPTMethodDescriptor*,nsXPTCMiniVariant*)(this = 0x207a3f78, methodIndex = 21, info = 0x209e3d50, params = 0x2ff1fbec), line 559 in "xpcwrappedjs.cpp"
PrepareAndDispatch(self = 0x207a3de8, methodIndex = 21, args = 0x2ff1febc, gprData = 0x2ff1fe18, fprData = 0x2ff1fe34), line 198 in "xptcstubs_ppc_aix.cpp"

I have narrowed it down ..
When the control reaches xpcom/glue/nsCOMPtr.cpp:47
i.e. status = mRawPtr->QueryInterface(aIID, answer);
I find the value of mRawPtr as (nil).

I saw a bug related to "nsQueryInterface" 
https://bugzilla.mozilla.org/show_bug.cgi?id=493281
not sure if this has anything to do :




Reproducible: Always

Steps to Reproduce:
1.click on Bookmarks
2.click on "Bookmark This Page" 

Actual Results:  
32 bit -> dumps core
64 bit -> nothing happens .. Error in error-console as described in details

Expected Results:  
a pop-up should come up "Page Bookmarked" asking for Name, tags etc.

My .mozconfig file looks like this :

# cat .mozconfig
export MOZ_ENABLE_COREXFONTS=1
ac_add_options --prefix=/usr/mozilla/firefox
ac_add_options --bindir=/usr/mozilla/firefox
ac_add_options --libdir=/usr/mozilla/firefox
ac_add_options --datadir=/usr/mozilla/firefox
mk_add_options MOZ_CO_PROJECT=browser
ac_add_options --enable-application=browser
ac_add_options --disable-tests
ac_add_options --disable-auto-deps
ac_add_options --enable-crypto
ac_add_options --disable-gnomevfs

ac_add_options --enable-extensions=default
ac_add_options --enable-svg
ac_add_options --enable-official-branding

export FT2_CONFIG=/opt/freeware/bin/freetype-config
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-dbg
ac_add_options --enable-default-mozilla-five-home=/usr/mozilla/firefox
mk_add_options MOZ_MAKE_FLAGS=-j4
ac_add_options --enable-debug=-g
#some cairo error comes(always) when I run firefox if I don't build it by #disabling libxul
ac_add_options --disable-libxul
ac_add_options --disable-libidl
ac_add_options --disable-dbus
#added for more information
ac_add_options --enable-default-toolkit=cairo-gtk2
ac_add_options --disable-optimize
#ac_add_options --enable-optimize="-O2 -qmaxmem=-1 -qalias=noansi -qlanglvl=stdc99 -bbigtoc"
# XFT support is not available on AIX
ac_add_options --enable-xft
# Don't build against system JPEG because libjpeg.a conflicts with Java 1.4's
# version.
# ac_add_options --with-system-jpeg
ac_add_options --without-system-png
ac_add_options --with-system-zlib
PATH=/usr/bin:/usr/sbin:/usr/bin/X11:/sbin:/usr/vac/bin:/usr/vacpp/bin
PERL=/usr/bin/perl
CC=xlc_r
CXX=xlC_r
LANG=C

Comment 1

[Marco Bonardo [:mak]]

have you tried with current version (3.5.xx)?

Comment 2

[Sangeeth]

yes I have also tried 3.5.2.
The results for 64 bit are same .. I did not try to make a 32 bit build.

Comment 3

[Sangeeth]

I can debug into the problem if someone can help me understand under what circumstances "mRawPtr" will be (nil). Maybe that can help me get to the root of the problem.

Comment 4

[Tyler Downer [He/Him]]

Please try with 3.5.3 or later. That is the current. I am curious if you get this in a new profile with no changes.

Comment 5

[Sangeeth]

Yes, I do get this same problem in a fresh new profile.

Ok, I'll try to build 3.5.3 or later.

Meanwhile can someone help me understand the stack-trace in more detail. I'm interested to dig deeper into the problem.

Comment 6

[Tyler Downer [He/Him]]

Reporter, are you still seeing this issue with Firefox 3.6.13 or later in safe mode or a fresh profile? If not, please close. These links can help you in your testing.
http://support.mozilla.com/kb/Safe+Mode
http://support.mozilla.com/kb/Managing+profiles

Comment 7

[Sangeeth]

This bug is fixed through the defect https://bugzilla.mozilla.org/show_bug.cgi?id=516667

Thanks