52307 - clicking on H. Line causes crash

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P1)

Description

[sujay]

using 9/12 build of netscape

1) launch netscape
2) launch composer
3) insert H. Line

single click on that H. Line or double click on it...

either way it crashes....Charley and I saw this together...

all platforms.

Comment 1

[Charles Manske]

Steve changed something about hr that probably caused this.
Please look at 45387 as well -- may be related.

Comment 2

[buster]

next on my list...

Comment 3

[buster]

does this only happen in the editor, or does it happen in the browser/viewer as 
well?

Comment 4

[buster]

trivial fix.  patch attached for review momentarily.  mikey?

Comment 5

[buster]

Attachment: proposed fix, just added a check for null child

Comment 6

[Charles Manske]

I'll review it if the attached patch has some linefeeds in it (kinda hard to
read)!

Comment 7

[buster]

Attachment: same patch, hopefully with line breaks.

Comment 8

[buster]

got verbal approval for nsbeta3+ from chris karnaze, walked through the problem 
and the code with him, though I'd still like a review from someone in editor 
land.

Comment 9

[Charles Manske]

Looks good to me - if you can click on an HR in Composer and it doesn't blow
up, fine. (Can't test right now because of big checkin rebuild.)

Comment 10

[buster]

fix checked in

Comment 11

[buster]

*** Bug 52529 has been marked as a duplicate of this bug. ***

Comment 12

[sujay]

verified in 9/14 build.