a possible problem in nsGtkIMEHelper.cpp

RESOLVED FIXED

Status

()

Core
Internationalization
P3
normal
RESOLVED FIXED
17 years ago
17 years ago

People

(Reporter: Shanjian Li, Assigned: Masaki Katakai)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
While I was reading XIM related code, the following lines came into my eyes.
It seems a "break" is missing after line 255. It might be a problem, though
we do not know if it causes any problem on user's prospective.

mozilla/ widget/ src/ gtk/ nsGtkIMEHelper.cpp
244     for (pFeedbackAttr = feedbackAttr;
245          pFeedbackAttr < &feedbackAttr[composeUniStringLen];
246          pFeedbackAttr++) {
247       switch (*preeditFeedback++) {
248       case XIMReverse:
249         *pFeedbackAttr = NS_TEXTRANGE_SELECTEDRAWTEXT;
250         break;
251       case XIMUnderline:
252         *pFeedbackAttr = NS_TEXTRANGE_CONVERTEDTEXT;
253         break;
254       case XIMHighlight:
255         *pFeedbackAttr = NS_TEXTRANGE_SELECTEDCONVERTEDTEXT;
256       default:
257         *pFeedbackAttr = NS_TEXTRANGE_RAWINPUT;
258       }
259     }

Updated

17 years ago
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Comment 1

17 years ago
The code in the comment has been fully tested.
want to take a code review by somebody@netscape.com.
to get "r=".

Updated

17 years ago
Target Milestone: --- → M19

Updated

17 years ago
Keywords: review

Updated

17 years ago
QA Contact: teruko → shanjian
(Assignee)

Comment 2

17 years ago
I found kinput2 of Linux uses XIMHighlight so we should fix this.
I'll take over.
(Assignee)

Comment 3

17 years ago
Created attachment 34476 [details] [diff] [review]
just add break; line
(Assignee)

Comment 4

17 years ago
Chris,

I have corrected by adding a "break;" line. Some IME uses XIMHighlight
so we shouldn't use the same attribute with NS_TEXTRANGE_RAWINPUT.

I need r=/sr= for this. Thank you.

(Reporter)

Comment 5

17 years ago
r=shanjian
sr=blizzard
(Assignee)

Comment 7

17 years ago
fix checked in.

Toshi, please assign to me or mark it as FIXED.

Shanjian, Chris, thank you very much for reviewing.

Comment 8

17 years ago
reassign to katakai@japan.sun.com
Assignee: tajima → katakai
Status: ASSIGNED → NEW

Comment 9

17 years ago
fix is in
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.