523134 - Unresponsive script dialog on startup: TileManager.js:516

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Ideally we shouldn't be doing anything in chrome that would be locking up the UI like this. Not sure what other information would be helpful though.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

got this dialog again, this time pointing to line 404

Comment 2

[Aakash Desai [:aakashd]]

Yeah, I'm seeing this across builds (via the Omnia 2 and HTC Touch Pro):

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2b1pre) Gecko/20091019 Fennec/1.0a4pre

and

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20091019 Fennec/1.0a4pre

I'm upping the severity of the bug as well.

Comment 3

[Doug Turner (:dougt)]

line 528 from todays build.

Comment 4

[Doug Turner (:dougt)]

527  inBounds: function inBounds(i, j) {
528    return (0 <= i && 0 <= j && i <= this.iBound && j <= this.jBound);
529  },

helpful, not sure.

Comment 5

[Aakash Desai [:aakashd]]

That's weird, I'm not seeing the dialog for the past two days on both 1.9.2 and trunk.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

bisecting points to http://hg.mozilla.org/mozilla-central/rev/09a701210197 backing that out resolves this for me

Comment 7

[Doug Turner (:dougt)]

gal, does anything look odd for ARM on WINCE here? ^

Comment 8

[Andreas Gal :gal]

My guess would be this hunk here. The rest looks ineffectual.

   2.27 +#ifdef NJ_SOFTFLOAT
    2.28 +        if (!ARM_VFP && (op == LIR_fcall || op == LIR_qcall))
    2.29                  op = LIR_callh;
    2.30 -        }
    2.31 +#endif

Comment 9

[Brad Lassey [:blassey] (use needinfo?)]

looks like bisect found the right changeset.  I built with changeset 0316ea5adbe1 and got the unresponsive script dialog on startup. I then backed out 09a701210197 and rebuilt and the unresponsive script dialog went away.

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/ffe8566df7b1 to backout the change that gal identified in comment 8.

Leaving the bug open for Gal to post a fixed up patch.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

I filed bug 527277 on any potential followups...

Comment 12

[Aakash Desai [:aakashd]]

verified FIXED on builds (HTC Touch Pro and Omnia 2):


Mozilla/5.0 (Windows; U; Window3sCE 5.2; en-US; rv:1.9.2b3pre) Gecko/20091109 Namoroka/3.6b2pre Fennec/1.0a4pre

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20091109 Fennec/1.0a4pre