523214 - require a CallInfo in all fragments we assemble [nanojit]

Status: RESOLVED WONTFIX

(Core Graveyard :: Nanojit, defect)

Description

[Andreas Gal :gal]

Architectures with abis that mix register and stack use require the full signature to figure out the stack offsets for each LIR_[fiq]param as it is being assembled. This patch embeds a CallInfo pointer into the fragment to provide this information (currently unused, except for the abi, next patch will use this information).

Comment 1

[Andreas Gal :gal]

Attachment: patch

Comment 2

[Rick Reitmaier]

I like the idea...getting abi off of the buffer makes sense to me.

Comment 3

[Andreas Gal :gal]

Comment on attachment 407109 [details] [diff] [review]
patch

This is going to need work in tamarin-redux to populate ->callInfo there as well.

Comment 4

[Rick Reitmaier]

Comment on attachment 407109 [details] [diff] [review]
patch

Good start...not sure if anyone is actively looking at this still.

Comment 5

[Nochum Sossonko [:Natch]]

These bugs are all part of a search I made for js bugs that are getting lost in transit:

http://tinyurl.com/jsDeadEndBugs

They all have a review+'ed, non-obsoleted patch and are not marked fixed-in-tracemonkey or checkin-needed but have not seen any activity in 300 days. Some of these got lost simply because the assignee/patch provider never requested a checkin, or just because they were forgotten about.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Edwin, does Nanojit want this?

Comment 7

[Nicholas Nethercote [inactive]]

Nanojit has been dead for several years. Its Bugzilla component has been moved to the graveyard (bug 984276).

I checked all the open bugs. They're all uninteresting, so I'm WONTFIXing them all. Apologies for the bugspam.