523312 - address some nits in aboutSupport.xhtml

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

constants are uppercase, "for each...in" shouldn't be used for arrays.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 407250 [details] [diff] [review]
patch

I actually prefer escaping the periods with [.], I think...

Comment 2

[Dão Gottwald [:dao]]

(In reply to comment #1)
> (From update of attachment 407250 [details] [diff] [review])
> I actually prefer escaping the periods with [.], I think...

It's really uncommon, though, and thus not really more readable.

Comment 3

[Curtis Bartley [:cbartley]]

Hold on guys.  First, I used the "[.]" escape for a reason, but more than that, I'm not even convinced that the "for each" is a problem.  I'm going to raise the latter issue on bug 519077 where there's a larger audience.

Comment 4

[Dão Gottwald [:dao]]

(In reply to comment #3)
> Hold on guys.  First, I used the "[.]" escape for a reason,

I know, and I disagree.

Comment 5

[Dão Gottwald [:dao]]

However, [.] is not why I filed this bug and I'm ok with leaving it alone.

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/e3c59861b5e4