523323 - Page Title Empty in PDF Printing Dialogue

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Daniel E.]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a1pre) Gecko/20091019 Minefield/3.7a1pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a1pre) Gecko/20091019 Minefield/3.7a1pre

In former version of Mozilla Firefox, the title of a page to be 'printed' as PDF was automatically suggested as file name for the PDF.

In the current trunk versions, that is no longer the case.

Reproducible: Always

Steps to Reproduce:
1. Open any Web page, e.g. http://www.mozilla.org/
2. Open print dialogue (Command-P)
3. Click PDF, then Save as PDF …
Actual Results:  
'.pdf.pdf' is suggested as file name.

Expected Results:  
'Mozilla.org - Home of the Mozilla Project.pdf' should be suggested as file name.

Comment 1

[philippe (part-time)]

It doesn't always happen exactly line that.

STR:
1. start up the browser
2. load http://mozilla.org
3. Print > save as PDF

AR: 'untitled.pdf' is suggested (which in itself is wrong).

STR2:
1. visit a page with flash content (whatever youtube page will do)
2. load http://mozilla.org
3. Print > save as PDF

AR: '.pdf.pdf' is suggested

regression range:
fails
Gecko/20091001 Minefield/3.7a1pre
http://hg.mozilla.org/mozilla-central/rev/51710e0ba8a3
works
Gecko/20090930 Minefield/3.7a1pre
http://hg.mozilla.org/mozilla-central/rev/7a75cd337fda

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7a75cd337fda&tochange=51710e0ba8a3

--> probably a regression from bug 456646

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Stuart fixed this bug (in its many variants with different STRs/ARs) before in the old code; in case it's helpful, see bug 312018, bug 303547, and bug 407434.

Comment 3

[Markus Stange [:mstange]]

Attachment: v1

That was helpful indeed. This patch just restores the code from bug 312018.

Comment 4

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/2765d0fc3c9e

Comment 5

[Markus Stange [:mstange]]

Comment on attachment 409328 [details] [diff] [review]
v1

I'll just roll this patch into the 1.9.2 one in bug 520494.