Closed Bug 523389 Opened 16 years ago Closed 16 years ago

once we hit soft limit can fail allocations should fail and large allocations that would trigger the soft limit should also fail

Categories

(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P3)

Product:
Tamarin Graveyard
Component:
Garbage Collection (mmGC)
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
flash10.1

People

(Reporter: treilly, Assigned: treilly)

References

Details

Attachments

(2 files)

fail soft limit crossing canFail allocs
722 bytes, patch
lhansen
: superreview+
Details | Diff | Splinter Review
don't fire callbacks in this case
421 bytes, patch
lhansen
: superreview+
Details | Diff | Splinter Review
No description provided.
Priority: -- → P3
Target Milestone: --- → flash10.1
Attachment #413322 - Flags: superreview?(lhansen)
Attachment #413322 - Flags: review?(bgetlin)
Status: NEW → ASSIGNED
Attachment #413322 - Flags: superreview?(lhansen) → superreview+
Tommy, I'm not sure bgetlin has review privileges, may want to ping him directly.
Attachment #413322 - Flags: review?(bgetlin)
changeset: 3182:d7d9ba597cbe
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #415424 - Flags: superreview?
Attachment #415424 - Flags: superreview? → superreview?(lhansen)
additional tweak from field testing, in cases where the kCanFail allocation is a big one we can safely recover from its overkill to send the notifications. Also since we keep the memory and return NULL it doesn't really make sense to say we hit the limit.
Attachment #415424 - Flags: superreview?(lhansen) → superreview+
pushed 3235
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Engineering work item. Marking as verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: