Closed Bug 523396 Opened 10 years ago Closed 10 years ago

Tune N810's tile capacity down to 15

Categories

(Firefox for Android Graveyard :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
fennec1.0b5

People

(Reporter: stechz, Assigned: mfinkle)

Details

Attachments

(1 file)

aakashd found 15 to be much less crashy than the default 30.
tracking-fennec: --- → ?
seems like the cache should be driven by memory pressure rather than a preference.
(In reply to comment #1)
> seems like the cache should be driven by memory pressure rather than a
> preference.

We currently don't resize the cache based on memory. We allocate the canvas tiles right away.
Attached patch patchSplinter Review
This patch adds support for sane defaults, based on the device. It adds a new mode to the "tiles.cache.size" pref. If set to -1, we use system-info to find the device type and set a default number of tiles.

I only use the -1 mode for hildon as windows mobile is not yet supported by system-info. Also, we don't know the best choices for WinMo either.

Defaults:
N900 = 26 tiles
N8XX = 10 tiles
unknown device = 6 tiles (just enough to function)
Assignee: nobody → mark.finkle
Attachment #408386 - Flags: review?(doug.turner)
Comment on attachment 408386 [details] [diff] [review]
patch

Does sysInfo.getProperty throw if a value isn't found?  I always forget which xpcom methods throw on "not-found" failures.

why 6 instead of 10?  If you use 10, you could save yourself that second case cause.

maybe change:
(-1 = choose based on device)

to

(When -1 is set, we default to very small value for the number of tiles unless we know about the device in which case we set this to an optimal value.)

verbose, but sometimes that helps.

Please fix up the nits.
Attachment #408386 - Flags: review?(doug.turner) → review+
(In reply to comment #4)
> (From update of attachment 408386 [details] [diff] [review])
> Does sysInfo.getProperty throw if a value isn't found?  I always forget which
> xpcom methods throw on "not-found" failures.

sysInfo.getProperty does throw, but sysInfo.get does not - changed

> why 6 instead of 10?  If you use 10, you could save yourself that second case
> cause.

I wanted a rock-bottom case. The N8XX can handle a bit more than rock-bottom

> maybe change:
> (-1 = choose based on device)
> 
> to
> 
> (When -1 is set, we default to very small value for the number of tiles unless
> we know about the device in which case we set this to an optimal value.)

Done
pushed:
https://hg.mozilla.org/mobile-browser/rev/b0971fd3fe67
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → B5
verified FIXED on build:

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20091027
Fennec/1.0b5pre
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.